Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2158393002: Make the Scope constructors less reliant on SetDefaults to magically set flags (Closed)

Created:
4 years, 5 months ago by Toon Verwaest
Modified:
4 years, 5 months ago
Reviewers:
adamk, marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make the Scope constructors less reliant on SetDefaults to magically set flags BUG=v8:5209 Committed: https://crrev.com/f52263ece7354870a14de8d1aedceef069d502bf Cr-Commit-Position: refs/heads/master@{#37894}

Patch Set 1 #

Patch Set 2 : Move unresolved_(nullptr) into SetDefaults #

Patch Set 3 : Reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -49 lines) Patch
M src/ast/scopes.h View 2 4 chunks +5 lines, -9 lines 0 comments Download
M src/ast/scopes.cc View 1 2 5 chunks +39 lines, -40 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Toon Verwaest
ptal
4 years, 5 months ago (2016-07-19 14:30:54 UTC) #2
adamk
This'll be easier to review once https://codereview.chromium.org/2160943004/ lands (many of the diffs only have to ...
4 years, 5 months ago (2016-07-19 20:51:54 UTC) #3
Toon Verwaest
That was unintended, my apologies. Patch 3 contains the diff.
4 years, 5 months ago (2016-07-20 07:25:32 UTC) #4
marja
lgtm
4 years, 5 months ago (2016-07-20 08:09:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158393002/40001
4 years, 5 months ago (2016-07-20 08:34:07 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/19818)
4 years, 5 months ago (2016-07-20 08:43:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158393002/40001
4 years, 5 months ago (2016-07-20 08:50:17 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-20 09:01:24 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 09:02:32 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f52263ece7354870a14de8d1aedceef069d502bf
Cr-Commit-Position: refs/heads/master@{#37894}

Powered by Google App Engine
This is Rietveld 408576698