Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2158363006: Removed _lastSeenWindowID ivar from CRWWebController as unused. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/ui/crw_web_controller.mm
diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm
index 77a3864e74d0b585dec24706f90389c6490a012e..85392b8bfe086fa93d0d4d2a6aabcd90b6c0e923 100644
--- a/ios/web/web_state/ui/crw_web_controller.mm
+++ b/ios/web/web_state/ui/crw_web_controller.mm
@@ -325,8 +325,6 @@ NSError* WKWebViewErrorWithSource(NSError* error, WKWebViewErrorSource source) {
// TODO(droger): Remove |_observerBridges| when all CRWWebControllerObservers
// are converted to WebStateObservers.
ScopedVector<web::WebControllerObserverBridge> _observerBridges;
- // |windowId| that is saved when a page changes. Used to detect refreshes.
- base::scoped_nsobject<NSString> _lastSeenWindowID;
// YES if a user interaction has been registered at any time once the page has
// loaded.
BOOL _userInteractionRegistered;
@@ -1040,7 +1038,6 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;
[[CRWJSInjectionReceiver alloc] initWithEvaluator:self]);
_windowIDJSManager.reset([(CRWJSWindowIdManager*)[_jsInjectionReceiver
instanceOfClass:[CRWJSWindowIdManager class]] retain]);
- _lastSeenWindowID.reset();
_webViewProxy.reset(
[[CRWWebViewProxyImpl alloc] initWithWebController:self]);
[[_webViewProxy scrollViewProxy] addObserver:self];
@@ -3204,7 +3201,6 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;
- (void)resetDocumentSpecificState {
_lastUserInteraction.reset();
_clickInProgress = NO;
- _lastSeenWindowID.reset([[_windowIDJSManager windowId] copy]);
}
- (void)didStartLoadingURL:(const GURL&)url updateHistory:(BOOL)updateHistory {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698