Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2158363004: [DevTools] Avoid dereferencing null pointer (Closed)

Created:
4 years, 5 months ago by eostroukhov-old
Modified:
4 years, 5 months ago
Reviewers:
kozy, dgozman, alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Avoid dereferencing null pointer Fixing an issue when a method was called on a null pointer. BUG=629636 Committed: https://crrev.com/c3b3d4537540294a5e52d5c7ffabbf1c32c13646 Cr-Commit-Position: refs/heads/master@{#406456}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
eostroukhov
4 years, 5 months ago (2016-07-19 21:55:35 UTC) #2
alph
lgtm
4 years, 5 months ago (2016-07-19 22:25:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158363004/1
4 years, 5 months ago (2016-07-19 23:08:36 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 02:05:02 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 02:07:37 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3b3d4537540294a5e52d5c7ffabbf1c32c13646
Cr-Commit-Position: refs/heads/master@{#406456}

Powered by Google App Engine
This is Rietveld 408576698