Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 2158353002: Makes chrome://md-settings an invalid URL in incognito mode (Closed)

Created:
4 years, 5 months ago by Moe
Modified:
4 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, Dan Beam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes chrome://md-settings an invalid URL in incognito mode BUG=602211 Committed: https://crrev.com/7f06f92925b46c21ea7ef8ccbb57618e3b697336 Cr-Commit-Position: refs/heads/master@{#406522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/browser_navigator.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Moe
Hi sky@, Please review this CL. chrome://settings/ and chrome://md-settings should act the same when opened ...
4 years, 5 months ago (2016-07-19 11:56:39 UTC) #4
sky
LGTM
4 years, 5 months ago (2016-07-19 17:52:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158353002/1
4 years, 5 months ago (2016-07-20 09:03:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 09:08:50 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 09:08:51 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 09:10:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f06f92925b46c21ea7ef8ccbb57618e3b697336
Cr-Commit-Position: refs/heads/master@{#406522}

Powered by Google App Engine
This is Rietveld 408576698