Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: src/ast/scopes.h

Issue 2158343002: Fix: Don't use Isolate during scope resolution. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: (streamlined the rebase) Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ast/scopes.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/scopes.h
diff --git a/src/ast/scopes.h b/src/ast/scopes.h
index 397a1dbd05a1dfb4e83f97019e96723b5153ae69..e9dbda7be865e83190f5273908891073eaf3329c 100644
--- a/src/ast/scopes.h
+++ b/src/ast/scopes.h
@@ -157,9 +157,9 @@ class Scope: public ZoneObject {
// Declare a parameter in this scope. When there are duplicated
// parameters the rightmost one 'wins'. However, the implementation
// expects all parameters to be declared and from left to right.
- Variable* DeclareParameter(
- const AstRawString* name, VariableMode mode,
- bool is_optional, bool is_rest, bool* is_duplicate);
+ Variable* DeclareParameter(const AstRawString* name, VariableMode mode,
+ bool is_optional, bool is_rest, bool* is_duplicate,
+ AstValueFactory* ast_value_factory);
// Declare a local variable in this scope. If the variable has been
// declared before, the previously declared variable is returned.
@@ -665,6 +665,8 @@ class Scope: public ZoneObject {
bool scope_uses_arguments_;
// This scope uses "super" property ('super.foo').
bool scope_uses_super_property_;
+ // This scope has a parameter called "arguments".
+ bool has_arguments_parameter_;
// This scope contains an "use asm" annotation.
bool asm_module_;
// This scope's outer context is an asm module.
@@ -777,16 +779,18 @@ class Scope: public ZoneObject {
// Predicates.
bool MustAllocate(Variable* var);
bool MustAllocateInContext(Variable* var);
- bool HasArgumentsParameter(Isolate* isolate);
// Variable allocation.
void AllocateStackSlot(Variable* var);
void AllocateHeapSlot(Variable* var);
- void AllocateParameterLocals(Isolate* isolate);
- void AllocateNonParameterLocal(Isolate* isolate, Variable* var);
- void AllocateDeclaredGlobal(Isolate* isolate, Variable* var);
- void AllocateNonParameterLocalsAndDeclaredGlobals(Isolate* isolate);
- void AllocateVariablesRecursively(Isolate* isolate);
+ void AllocateParameterLocals();
+ void AllocateNonParameterLocal(Variable* var,
+ AstValueFactory* ast_value_factory);
+ void AllocateDeclaredGlobal(Variable* var,
+ AstValueFactory* ast_value_factory);
+ void AllocateNonParameterLocalsAndDeclaredGlobals(
+ AstValueFactory* ast_value_factory);
+ void AllocateVariablesRecursively(AstValueFactory* ast_value_factory);
void AllocateParameter(Variable* var, int index);
void AllocateReceiver();
« no previous file with comments | « no previous file | src/ast/scopes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698