Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: src/ast/scopes.h

Issue 2158343002: Fix: Don't use Isolate during scope resolution. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ast/scopes.cc » ('j') | src/ast/scopes.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/scopes.h
diff --git a/src/ast/scopes.h b/src/ast/scopes.h
index cde826a116192e54fcf1d1af8b2cbb011700b758..7992846dcae36770e5c0d884632d561a9b44dc79 100644
--- a/src/ast/scopes.h
+++ b/src/ast/scopes.h
@@ -663,6 +663,8 @@ class Scope: public ZoneObject {
bool scope_uses_arguments_;
// This scope uses "super" property ('super.foo').
bool scope_uses_super_property_;
+ // This scope has a parameter called "arguments".
+ bool has_arguments_parameter_;
// This scope contains an "use asm" annotation.
bool asm_module_;
// This scope's outer context is an asm module.
@@ -775,16 +777,15 @@ class Scope: public ZoneObject {
// Predicates.
bool MustAllocate(Variable* var);
bool MustAllocateInContext(Variable* var);
- bool HasArgumentsParameter(Isolate* isolate);
// Variable allocation.
void AllocateStackSlot(Variable* var);
void AllocateHeapSlot(Variable* var);
- void AllocateParameterLocals(Isolate* isolate);
- void AllocateNonParameterLocal(Isolate* isolate, Variable* var);
- void AllocateDeclaredGlobal(Isolate* isolate, Variable* var);
- void AllocateNonParameterLocalsAndDeclaredGlobals(Isolate* isolate);
- void AllocateVariablesRecursively(Isolate* isolate);
+ void AllocateParameterLocals();
+ void AllocateNonParameterLocal(Variable* var);
+ void AllocateDeclaredGlobal(Variable* var);
+ void AllocateNonParameterLocalsAndDeclaredGlobals();
+ void AllocateVariablesRecursively();
void AllocateParameter(Variable* var, int index);
void AllocateReceiver();
« no previous file with comments | « no previous file | src/ast/scopes.cc » ('j') | src/ast/scopes.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698