Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Issue 2158333002: Eagerly set arguments_, new_target_ and ths_function_ in Scope (Closed)

Created:
4 years, 5 months ago by Toon Verwaest
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Eagerly set arguments_, new_target_ and ths_function_ Scope, and unset if we don't need to allocate them. This probably slightly speeds up AllocateParameterLocals, but more importantly it removes ast_value_factory_ uses. If we get rid of ast_value_factory from Scope it's easier to lazily allocate it later from within a ScopeState object. BUG=v8:5209 Committed: https://crrev.com/3442519d566889055f7113a76e36f7ea98c01855 Cr-Commit-Position: refs/heads/master@{#37868}

Patch Set 1 #

Patch Set 2 : Also this_function_ and new_target_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M src/ast/scopes.cc View 1 4 chunks +30 lines, -30 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Toon Verwaest
ptal
4 years, 5 months ago (2016-07-19 11:03:56 UTC) #2
marja
lgtm
4 years, 5 months ago (2016-07-19 11:09:00 UTC) #3
marja
still lgtm
4 years, 5 months ago (2016-07-19 11:21:30 UTC) #5
Michael Starzinger
LGTM.
4 years, 5 months ago (2016-07-19 12:56:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158333002/20001
4 years, 5 months ago (2016-07-19 12:58:45 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 13:00:46 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 13:01:56 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3442519d566889055f7113a76e36f7ea98c01855
Cr-Commit-Position: refs/heads/master@{#37868}

Powered by Google App Engine
This is Rietveld 408576698