Issue 215833002: window.atob() returns wrong value when given a string container only white spaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 215833002: window.atob() returns wrong value when given a string container only white spaces (Closed)

Created:
6 years, 9 months ago by Inactive

Modified:
6 years, 9 months ago

Reviewers:
tkent, abarth-chromium, eseidel

CC:
blink-reviews, Mikhail, adamk+blink_chromium.org, Inactive, abarth-chromium, tkent

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

window.atob() returns wrong value when given a string container only white spaces window.atob() returns wrong value when given a string container only white spaces. The reason was that base64DecodeInternal() was calling Vector::grow() before the loop but failed to call Vector::shrink() in case of early return. R= BUG=357332 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170264

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -5 lines)			Patch
M	LayoutTests/fast/dom/Window/atob-btoa.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/fast/dom/Window/atob-btoa-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/wtf/text/Base64.cpp	View	1 chunk	+17 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/215833002/1

6 years, 9 months ago (2014-03-28 03:17:44 UTC) #3

Message was sent while issue was closed.

Change committed as 170264

Expand Messages | Collapse Messages