Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: components/tracing/core/proto_zero_message_handle.h

Issue 2158323005: tracing v2: Introduce handles for safe usage of ProtoZeroMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: final nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/tracing/core/proto_zero_message.cc ('k') | components/tracing/core/proto_zero_message_handle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/tracing/core/proto_zero_message_handle.h
diff --git a/components/tracing/core/proto_zero_message_handle.h b/components/tracing/core/proto_zero_message_handle.h
new file mode 100644
index 0000000000000000000000000000000000000000..2f83ec9638f0d400a96eec74c159c0730eab62f7
--- /dev/null
+++ b/components/tracing/core/proto_zero_message_handle.h
@@ -0,0 +1,69 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_TRACING_CORE_PROTO_ZERO_MESSAGE_HANDLE_H_
+#define COMPONENTS_TRACING_CORE_PROTO_ZERO_MESSAGE_HANDLE_H_
+
+#include "base/macros.h"
+#include "components/tracing/tracing_export.h"
+
+namespace tracing {
+namespace v2 {
+
+class ProtoZeroMessage;
+
+// ProtoZeroMessageHandle allows to decouple the lifetime of a proto message
+// from the underlying storage. It gives the following guarantees:
+// - The underlying message is finalized (if still alive) if the handle goes
+// out of scope.
+// - In Debug / DCHECK_ALWAYS_ON builds, the handle becomes null once the
+// message is finalized. This is to enforce the append-only API. For instance
+// when adding two repeated messages, the addition of the 2nd one forces
+// the finalization of the first.
+// Think about this as a WeakPtr<ProtoZeroMessage> which calls
+// ProtoZeroMessage::Finalize() when going out of scope.
+
+class TRACING_EXPORT ProtoZeroMessageHandleBase {
+ public:
+ ~ProtoZeroMessageHandleBase();
+
+ // Move-only type.
+ ProtoZeroMessageHandleBase(ProtoZeroMessageHandleBase&& other);
+ ProtoZeroMessageHandleBase& operator=(ProtoZeroMessageHandleBase&& other);
+
+ protected:
+ explicit ProtoZeroMessageHandleBase(ProtoZeroMessage*);
+ ProtoZeroMessage& operator*() const { return *message_; }
+ ProtoZeroMessage* operator->() const { return message_; }
+
+ private:
+ friend class ProtoZeroMessage;
+
+ void reset_message() { message_ = nullptr; }
+ void Move(ProtoZeroMessageHandleBase* other);
+
+ ProtoZeroMessage* message_;
+
+ DISALLOW_COPY_AND_ASSIGN(ProtoZeroMessageHandleBase);
+};
+
+template <typename T>
+class ProtoZeroMessageHandle : ProtoZeroMessageHandleBase {
+ public:
+ explicit ProtoZeroMessageHandle(T* message)
+ : ProtoZeroMessageHandleBase(message) {}
+
+ T& operator*() const {
+ return static_cast<T&>(ProtoZeroMessageHandleBase::operator*());
+ }
+
+ T* operator->() const {
+ return static_cast<T*>(ProtoZeroMessageHandleBase::operator->());
+ }
+};
+
+} // namespace v2
+} // namespace tracing
+
+#endif // COMPONENTS_TRACING_CORE_PROTO_ZERO_MESSAGE_HANDLE_H_
« no previous file with comments | « components/tracing/core/proto_zero_message.cc ('k') | components/tracing/core/proto_zero_message_handle.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698