Clarify GrGradientEffect key enum

Clarify GrGradientEffect key enum

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2158323003

Committed: https://skia.googlesource.com/skia/+/64e8e5dd0b24f0f49ff1c06b325705c92d0f9a16

[fmenozzi, 2016-07-19 14:29:03]

Description was changed from

==========
Clarify key enum

BUG=skia:
==========

to

==========
Clarify key enum

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2158323003
==========

[fmenozzi, 2016-07-19 14:29:26]

fmenozzi@google.com changed reviewers:
+ bsalomon@google.com

[fmenozzi, 2016-07-19 14:29:27]

ptal

[bsalomon, 2016-07-19 14:48:37]

Can you change the name of the CL to be slightly more descriptive, e.g. "Clarify
GrGradientEffect key enum"?

https://codereview.chromium.org/2158323003/diff/1/src/effects/gradients/SkGra...
File src/effects/gradients/SkGradientShaderPriv.h (right):

https://codereview.chromium.org/2158323003/diff/1/src/effects/gradients/SkGra...
src/effects/gradients/SkGradientShaderPriv.h:433: // Next two bits for 2/3 color
type
Maybe comment that using neither means texture? Or add kTextureKey?

https://codereview.chromium.org/2158323003/diff/1/src/effects/gradients/SkGra...
src/effects/gradients/SkGradientShaderPriv.h:437: // Next two bits for tilemode
Add these when you're ready to use them?

[fmenozzi, 2016-07-19 14:50:28]

Description was changed from

==========
Clarify key enum

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2158323003
==========

to

==========
Clarify GrGradientEffect key enum

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2158323003
==========

[fmenozzi, 2016-07-19 14:54:12]

Add Brian's suggestions, ptal

[fmenozzi, 2016-07-19 17:22:56]

bump

[bsalomon, 2016-07-19 17:24:01]

lgtm

[fmenozzi, 2016-07-19 17:24:46]

The CQ bit was checked by fmenozzi@google.com

[commit-bot: I haz the power, 2016-07-19 17:24:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 17:46:00]

Description was changed from

==========
Clarify GrGradientEffect key enum

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2158323003
==========

to

==========
Clarify GrGradientEffect key enum

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2158323003

Committed:
https://skia.googlesource.com/skia/+/64e8e5dd0b24f0f49ff1c06b325705c92d0f9a16
==========

[commit-bot: I haz the power, 2016-07-19 17:46:01]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/64e8e5dd0b24f0f49ff1c06b325705c92d0f9a16