Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2158303002: Begin porting CallSite to C++ (Closed)

Created:
4 years, 5 months ago by jgruber
Modified:
4 years, 5 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@remove-overflow-boilerplate
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Begin porting CallSite to C++ Committed: https://crrev.com/c8a0dce96c989ea56632613215aa172352cbf9ec Cr-Commit-Position: refs/heads/master@{#37975}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Total comments: 2

Patch Set 4 : Eager CallSite import and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+473 lines, -227 lines) Patch
M BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 2 2 chunks +57 lines, -4 lines 0 comments Download
M src/builtins/builtins.h View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
A src/builtins/builtins-callsite.cc View 1 2 3 1 chunk +389 lines, -0 lines 0 comments Download
M src/js/messages.js View 1 2 3 3 chunks +4 lines, -172 lines 0 comments Download
M src/messages.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 2 3 1 chunk +0 lines, -10 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M src/v8.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (16 generated)
jgruber
Sending this out before the overflow boilerplate commit hits. This is basically all of the ...
4 years, 5 months ago (2016-07-21 13:55:17 UTC) #14
Yang
LGTM with one comment. https://codereview.chromium.org/2158303002/diff/40001/src/js/messages.js File src/js/messages.js (right): https://codereview.chromium.org/2158303002/diff/40001/src/js/messages.js#newcode18 src/js/messages.js:18: var CallSite; Let's use utils.ImportNow ...
4 years, 5 months ago (2016-07-22 08:16:17 UTC) #15
jgruber
https://codereview.chromium.org/2158303002/diff/40001/src/js/messages.js File src/js/messages.js (right): https://codereview.chromium.org/2158303002/diff/40001/src/js/messages.js#newcode18 src/js/messages.js:18: var CallSite; On 2016/07/22 08:16:17, Yang wrote: > Let's ...
4 years, 5 months ago (2016-07-22 09:49:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158303002/60001
4 years, 5 months ago (2016-07-22 09:49:22 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-22 10:12:29 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 10:12:49 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c8a0dce96c989ea56632613215aa172352cbf9ec
Cr-Commit-Position: refs/heads/master@{#37975}

Powered by Google App Engine
This is Rietveld 408576698