Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2158283002:
deal with invalid readpixel format and type (Closed)
|
Created:
4 years, 5 months ago by xinghua.cao Modified:
4 years, 5 months ago Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptiondeal with invalid readpixel format and type
BUG=629042
TESTCASE=conformance2/reading/read-pixels-from-fbo-test.html on mesa+i965 platform
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/b1d177b84632df05a83e4c3edd340171f4e16324
Cr-Commit-Position: refs/heads/master@{#406547}
Patch Set 1 #
Total comments: 3
Patch Set 2 #Patch Set 3 : Address zhenyao's comment #Messages
Total messages: 31 (20 generated)
Description was changed from ========== deal with invalid readpixel format and type BUG=629042 TESTCASE=conformance2/reading/read-pixels-from-fbo-test.html on mesa+i965 platform ========== to ========== deal with invalid readpixel format and type BUG=629042 TESTCASE=conformance2/reading/read-pixels-from-fbo-test.html on mesa+i965 platform CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
xinghua.cao@intel.com changed reviewers: + qiankun.miao@intel.com, yunchao.he@intel.com
Please help to review it, thank you.
The CQ bit was checked by xinghua.cao@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Looks good to me with on minor suggestion. Thanks for fixing this. https://codereview.chromium.org/2158283002/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/2158283002/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/gles2_cmd_decoder.cc:5927: } Maybe" ? : " is simpler than if-else. You just need to define one variable is_valid_format_type.
https://codereview.chromium.org/2158283002/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/2158283002/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/gles2_cmd_decoder.cc:5929: !is_valid_type) { What it returns if the format/type is invalid?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== deal with invalid readpixel format and type BUG=629042 TESTCASE=conformance2/reading/read-pixels-from-fbo-test.html on mesa+i965 platform CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== deal with invalid readpixel format and type BUG=629042 TESTCASE=conformance2/reading/read-pixels-from-fbo-test.html on mesa+i965 platform CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
xinghua.cao@intel.com changed reviewers: + kbr@chromium.org, zmo@chromium.org
Ken&Mo: PTAL
LGTM. We have discussed this issue offline.
the code looks correct. I have some minor improvement suggestion. https://codereview.chromium.org/2158283002/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/2158283002/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/gles2_cmd_decoder.cc:5921: bool is_valid_format = true; You just need one is_valid, and you can initialize it to glGetError() == GL_NO_ERROR. You only need to check if *params is legal if is_valid is true.
The CQ bit was checked by xinghua.cao@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by xinghua.cao@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/07/19 16:42:38, Zhenyao Mo wrote: > the code looks correct. I have some minor improvement suggestion. > > https://codereview.chromium.org/2158283002/diff/1/gpu/command_buffer/service/... > File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): > > https://codereview.chromium.org/2158283002/diff/1/gpu/command_buffer/service/... > gpu/command_buffer/service/gles2_cmd_decoder.cc:5921: bool is_valid_format = > true; > You just need one is_valid, and you can initialize it to glGetError() == > GL_NO_ERROR. > > You only need to check if *params is legal if is_valid is true. zhenyao, please review it again, thank you.
lgtm
The CQ bit was checked by xinghua.cao@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from yunchao.he@intel.com Link to the patchset: https://codereview.chromium.org/2158283002/#ps40001 (title: "Address zhenyao's comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== deal with invalid readpixel format and type BUG=629042 TESTCASE=conformance2/reading/read-pixels-from-fbo-test.html on mesa+i965 platform CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== deal with invalid readpixel format and type BUG=629042 TESTCASE=conformance2/reading/read-pixels-from-fbo-test.html on mesa+i965 platform CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== deal with invalid readpixel format and type BUG=629042 TESTCASE=conformance2/reading/read-pixels-from-fbo-test.html on mesa+i965 platform CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== deal with invalid readpixel format and type BUG=629042 TESTCASE=conformance2/reading/read-pixels-from-fbo-test.html on mesa+i965 platform CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/b1d177b84632df05a83e4c3edd340171f4e16324 Cr-Commit-Position: refs/heads/master@{#406547} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/b1d177b84632df05a83e4c3edd340171f4e16324 Cr-Commit-Position: refs/heads/master@{#406547} |
