Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 2158273003: mus: Rename .*PointerWatcher.* to .*PointerDownWatcher.*. (Closed)

Created:
4 years, 5 months ago by riajiang
Modified:
4 years, 5 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, kalyank, sadrul, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Rename .*PointerWatcher.* to .*PointerDownWatcher.* to avoid confusion with PointerEventWatcher (https://codereview.chromium.org/2163453002/). Committed: https://crrev.com/b2db88d57e677ab3ff4b3fc7f58896603816053c Cr-Commit-Position: refs/heads/master@{#406584}

Patch Set 1 #

Patch Set 2 : Fix an include. #

Patch Set 3 : cl upload similarity #

Patch Set 4 : cl upload similarity #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -395 lines) Patch
M ash/ash.gyp View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M ash/aura/wm_shell_aura.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/aura/wm_shell_aura.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A ash/common/pointer_down_watcher_delegate.h View 3 4 1 chunk +28 lines, -0 lines 0 comments Download
D ash/common/pointer_watcher_delegate.h View 1 chunk +0 lines, -27 lines 0 comments Download
M ash/common/shelf/overflow_bubble.h View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M ash/common/shelf/overflow_bubble.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/shell_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/common/system/tray/tray_event_filter.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/common/system/tray/tray_event_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/wm_shell.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M ash/mus/shell_delegate_mus.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/mus/shell_delegate_mus.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/pointer_down_watcher_delegate_aura.h View 3 chunks +12 lines, -11 lines 0 comments Download
A + ash/pointer_down_watcher_delegate_aura.cc View 3 chunks +16 lines, -16 lines 0 comments Download
D ash/pointer_watcher_delegate_aura.h View 1 chunk +0 lines, -51 lines 0 comments Download
D ash/pointer_watcher_delegate_aura.cc View 1 chunk +0 lines, -65 lines 0 comments Download
M ash/shelf/shelf_tooltip_manager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf_tooltip_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/shell.h View 4 chunks +5 lines, -5 lines 0 comments Download
M ash/shell.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ash/sysui/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A ash/sysui/pointer_down_watcher_delegate_mus.h View 4 1 chunk +29 lines, -0 lines 0 comments Download
A ash/sysui/pointer_down_watcher_delegate_mus.cc View 3 4 1 chunk +25 lines, -0 lines 0 comments Download
D ash/sysui/pointer_watcher_delegate_mus.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ash/sysui/pointer_watcher_delegate_mus.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M ash/sysui/shell_delegate_mus.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/sysui/shell_delegate_mus.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/test/test_shell_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_shell_delegate.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/mus/window_manager_connection.h View 4 chunks +5 lines, -5 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 5 chunks +17 lines, -14 lines 0 comments Download
M ui/views/mus/window_manager_connection_unittest.cc View 5 chunks +19 lines, -19 lines 0 comments Download
A + ui/views/pointer_down_watcher.h View 3 chunks +7 lines, -7 lines 0 comments Download
D ui/views/pointer_watcher.h View 1 chunk +0 lines, -48 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/views_exports.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
riajiang
4 years, 5 months ago (2016-07-20 00:12:18 UTC) #6
sky
LGTM
4 years, 5 months ago (2016-07-20 15:27:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158273003/80001
4 years, 5 months ago (2016-07-20 15:37:34 UTC) #12
sadrul
lgtm++
4 years, 5 months ago (2016-07-20 16:10:56 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-07-20 16:41:19 UTC) #14
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/b2db88d57e677ab3ff4b3fc7f58896603816053c Cr-Commit-Position: refs/heads/master@{#406584}
4 years, 5 months ago (2016-07-20 16:43:14 UTC) #16
riajiang
4 years, 5 months ago (2016-07-21 19:36:22 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2167643005/ by riajiang@chromium.org.

The reason for reverting is: As discussed, changing PointerWatcher to watch for
all events instead..

Powered by Google App Engine
This is Rietveld 408576698