Landing Recent QUIC changes until 7/18/2016 11:21:53 UTC

Landing Recent QUIC changes until 7/18/2016 11:21:53 UTC

relnote: Use QuicAlarm::Update instead of QuicAlarm::Cancel/Set pairs. Not flag protected.
Merge internal change: 127703830
https://codereview.chromium.org/2166583002

relnote: Use UpdateImpl to cancel and set alarms. Guarded by quic_change_alarms_efficiently. Chromium doesn't support EpollAlarmQueue, this merge is to keep code consist.
Merge internal change: 127449992
https://codereview.chromium.org/2164483003

Convert callers of ProofSource::GetProof to use async interface (3/N)
This change converts the callpath
QuicCryptoServerConfig::EvaluateClientHello -> ProofSource::GetProof to
use the async version of the latter.
relnote: Converts one quic codepath to an async version of the same
functionality.  No functional change intended.  Protected by
reloadable_flag_enable_async_get_proof.
Merge internal change: 127330079
https://codereview.chromium.org/2153403002

relnote: Deprecate --reloadable_flag_quic_use_hash_in_scup
Merge internal change: 127145969
https://codereview.chromium.org/2156903002

relnote: Correctly use the ServerSessionHelper (aka the Dispatcher) to generate QUIC connection IDs. Protected by --reloadable_flag_quic_dispatcher_creates_id2.
Also deprecated --reloadable_flag_quic_dispatcher_creates_id which,
in hindsight, did the right thing for gfe/quic/  *sob*
Merge internal change: 127128172
https://codereview.chromium.org/2156853002/

BUG=

Committed: https://crrev.com/466daf4ddf20e4bd915d9dde2ddf9822be92b4f5
Cr-Commit-Position: refs/heads/master@{#406492}

[Zhongyi Shi, 2016-07-19 20:00:14]

zhongyi@chromium.org changed reviewers:
+ rch@chromium.org

[Zhongyi Shi, 2016-07-19 20:00:23]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 20:01:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Hamilton, 2016-07-19 21:14:52]

Please update the CL description as per
https://codereview.chromium.org/2164483003/ and also add links in the CL
description to each chromium CL.

Also, did you run the flag flip script?

[Ryan Hamilton, 2016-07-19 21:15:09]

Description was changed from

==========
Landing Recent QUIC changes until 7/18/2016 11:21:53 UTC

relnote: Use QuicAlarm::Update instead of QuicAlarm::Cancel/Set pairs. Not flag
protected.
Merge internal change: 127703830

relnote: Use NotifyChangedPriority when updating alarms instead of canceling and
reregistering. Guarded by quic_change_alarms_efficiently.

The current approach of calling Cancel() and Set() when updating alarms
causes worst-case alarm churn in the priority queue. The faster approach is to
use NotifyChangedPriority directly.
Merge internal change: 127449992

Convert callers of ProofSource::GetProof to use async interface (3/N)

This change converts the callpath
QuicCryptoServerConfig::EvaluateClientHello -> ProofSource::GetProof to
use the async version of the latter.

relnote: Converts one quic codepath to an async version of the same
functionality.  No functional change intended.  Protected by
reloadable_flag_enable_async_get_proof.

Merge internal change: 127330079

relnote: Deprecate --reloadable_flag_quic_use_hash_in_scup

Merge internal change: 127145969

relnote: Correctly use the ServerSessionHelper (aka the Dispatcher) to generate
QUIC connection IDs. Protected by --reloadable_flag_quic_dispatcher_creates_id2.

Also deprecated --reloadable_flag_quic_dispatcher_creates_id which,
in hindsight, did the right thing for gfe/quic/  *sob*

Merge internal change: 127128172

Also deprecated --gfe2_reloadable_flag_quic_dispatcher_creates_id which,
in hindsight, did the right thing for gfe/quic/ but not for
gfe/gfe2/quic/ *sob*

BUG=
==========

to

==========
Landing Recent QUIC changes until 7/18/2016 11:21:53 UTC

relnote: Use QuicAlarm::Update instead of QuicAlarm::Cancel/Set pairs. Not flag
protected.
Merge internal change: 127703830

relnote: Use NotifyChangedPriority when updating alarms instead of canceling and
reregistering. Guarded by quic_change_alarms_efficiently.

The current approach of calling Cancel() and Set() when updating alarms
causes worst-case alarm churn in the priority queue. The faster approach is to
use NotifyChangedPriority directly.
Merge internal change: 127449992

Convert callers of ProofSource::GetProof to use async interface (3/N)

This change converts the callpath
QuicCryptoServerConfig::EvaluateClientHello -> ProofSource::GetProof to
use the async version of the latter.

relnote: Converts one quic codepath to an async version of the same
functionality.  No functional change intended.  Protected by
reloadable_flag_enable_async_get_proof.

Merge internal change: 127330079

relnote: Deprecate --reloadable_flag_quic_use_hash_in_scup

Merge internal change: 127145969

relnote: Correctly use the ServerSessionHelper (aka the Dispatcher) to generate
QUIC connection IDs. Protected by --reloadable_flag_quic_dispatcher_creates_id2.

Also deprecated --reloadable_flag_quic_dispatcher_creates_id which,
in hindsight, did the right thing for gfe/quic/  *sob*

Merge internal change: 127128172

Also deprecated --reloadable_flag_quic_dispatcher_creates_id which,
in hindsight, did the right thing for gfe/quic/ but not for
gfe/gfe2/quic/ *sob*

BUG=
==========

[commit-bot: I haz the power, 2016-07-19 21:25:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 21:25:54]

Dry run: This issue passed the CQ dry run.

[Zhongyi Shi, 2016-07-19 22:23:41]

Description was changed from

==========
Landing Recent QUIC changes until 7/18/2016 11:21:53 UTC

relnote: Use QuicAlarm::Update instead of QuicAlarm::Cancel/Set pairs. Not flag
protected.
Merge internal change: 127703830

relnote: Use NotifyChangedPriority when updating alarms instead of canceling and
reregistering. Guarded by quic_change_alarms_efficiently.

The current approach of calling Cancel() and Set() when updating alarms
causes worst-case alarm churn in the priority queue. The faster approach is to
use NotifyChangedPriority directly.
Merge internal change: 127449992

Convert callers of ProofSource::GetProof to use async interface (3/N)

This change converts the callpath
QuicCryptoServerConfig::EvaluateClientHello -> ProofSource::GetProof to
use the async version of the latter.

relnote: Converts one quic codepath to an async version of the same
functionality.  No functional change intended.  Protected by
reloadable_flag_enable_async_get_proof.

Merge internal change: 127330079

relnote: Deprecate --reloadable_flag_quic_use_hash_in_scup

Merge internal change: 127145969

relnote: Correctly use the ServerSessionHelper (aka the Dispatcher) to generate
QUIC connection IDs. Protected by --reloadable_flag_quic_dispatcher_creates_id2.

Also deprecated --reloadable_flag_quic_dispatcher_creates_id which,
in hindsight, did the right thing for gfe/quic/  *sob*

Merge internal change: 127128172

Also deprecated --reloadable_flag_quic_dispatcher_creates_id which,
in hindsight, did the right thing for gfe/quic/ but not for
gfe/gfe2/quic/ *sob*

BUG=
==========

to

==========
Landing Recent QUIC changes until 7/18/2016 11:21:53 UTC

relnote: Use QuicAlarm::Update instead of QuicAlarm::Cancel/Set pairs. Not flag
protected.
Merge internal change: 127703830
https://codereview.chromium.org/2166583002

relnote: Use NotifyChangedPriority when updating alarms instead of canceling and
reregistering. Guarded by quic_change_alarms_efficiently.
The current approach of calling Cancel() and Set() when updating alarms
causes worst-case alarm churn in the priority queue. The faster approach is to
use NotifyChangedPriority directly.
Merge internal change: 127449992
https://codereview.chromium.org/2164483003

Convert callers of ProofSource::GetProof to use async interface (3/N)
This change converts the callpath
QuicCryptoServerConfig::EvaluateClientHello -> ProofSource::GetProof to
use the async version of the latter.
relnote: Converts one quic codepath to an async version of the same
functionality.  No functional change intended.  Protected by
reloadable_flag_enable_async_get_proof.
Merge internal change: 127330079
https://codereview.chromium.org/2153403002

relnote: Deprecate --reloadable_flag_quic_use_hash_in_scup
Merge internal change: 127145969
https://codereview.chromium.org/2156903002

relnote: Correctly use the ServerSessionHelper (aka the Dispatcher) to generate
QUIC connection IDs. Protected by --reloadable_flag_quic_dispatcher_creates_id2.
Also deprecated --reloadable_flag_quic_dispatcher_creates_id which,
in hindsight, did the right thing for gfe/quic/  *sob*
Merge internal change: 127128172
https://codereview.chromium.org/2156853002/

BUG=
==========

[Zhongyi Shi, 2016-07-19 22:31:55]

Description was changed from

==========
Landing Recent QUIC changes until 7/18/2016 11:21:53 UTC

relnote: Use QuicAlarm::Update instead of QuicAlarm::Cancel/Set pairs. Not flag
protected.
Merge internal change: 127703830
https://codereview.chromium.org/2166583002

relnote: Use NotifyChangedPriority when updating alarms instead of canceling and
reregistering. Guarded by quic_change_alarms_efficiently.
The current approach of calling Cancel() and Set() when updating alarms
causes worst-case alarm churn in the priority queue. The faster approach is to
use NotifyChangedPriority directly.
Merge internal change: 127449992
https://codereview.chromium.org/2164483003

Convert callers of ProofSource::GetProof to use async interface (3/N)
This change converts the callpath
QuicCryptoServerConfig::EvaluateClientHello -> ProofSource::GetProof to
use the async version of the latter.
relnote: Converts one quic codepath to an async version of the same
functionality.  No functional change intended.  Protected by
reloadable_flag_enable_async_get_proof.
Merge internal change: 127330079
https://codereview.chromium.org/2153403002

relnote: Deprecate --reloadable_flag_quic_use_hash_in_scup
Merge internal change: 127145969
https://codereview.chromium.org/2156903002

relnote: Correctly use the ServerSessionHelper (aka the Dispatcher) to generate
QUIC connection IDs. Protected by --reloadable_flag_quic_dispatcher_creates_id2.
Also deprecated --reloadable_flag_quic_dispatcher_creates_id which,
in hindsight, did the right thing for gfe/quic/  *sob*
Merge internal change: 127128172
https://codereview.chromium.org/2156853002/

BUG=
==========

to

==========
Landing Recent QUIC changes until 7/18/2016 11:21:53 UTC

relnote: Use QuicAlarm::Update instead of QuicAlarm::Cancel/Set pairs. Not flag
protected.
Merge internal change: 127703830
https://codereview.chromium.org/2166583002

relnote: Use UpdateImpl when updating alarms to canceling and reregistering the
alarm. Guarded by quic_change_alarms_efficiently. Chromium doesn't support
EpollAlarmQueue, this merge is to keep code consist. 
Merge internal change: 127449992
https://codereview.chromium.org/2164483003

Convert callers of ProofSource::GetProof to use async interface (3/N)
This change converts the callpath
QuicCryptoServerConfig::EvaluateClientHello -> ProofSource::GetProof to
use the async version of the latter.
relnote: Converts one quic codepath to an async version of the same
functionality.  No functional change intended.  Protected by
reloadable_flag_enable_async_get_proof.
Merge internal change: 127330079
https://codereview.chromium.org/2153403002

relnote: Deprecate --reloadable_flag_quic_use_hash_in_scup
Merge internal change: 127145969
https://codereview.chromium.org/2156903002

relnote: Correctly use the ServerSessionHelper (aka the Dispatcher) to generate
QUIC connection IDs. Protected by --reloadable_flag_quic_dispatcher_creates_id2.
Also deprecated --reloadable_flag_quic_dispatcher_creates_id which,
in hindsight, did the right thing for gfe/quic/  *sob*
Merge internal change: 127128172
https://codereview.chromium.org/2156853002/

BUG=
==========

[Zhongyi Shi, 2016-07-19 22:33:52]

Description was changed from

==========
Landing Recent QUIC changes until 7/18/2016 11:21:53 UTC

relnote: Use QuicAlarm::Update instead of QuicAlarm::Cancel/Set pairs. Not flag
protected.
Merge internal change: 127703830
https://codereview.chromium.org/2166583002

relnote: Use UpdateImpl when updating alarms to canceling and reregistering the
alarm. Guarded by quic_change_alarms_efficiently. Chromium doesn't support
EpollAlarmQueue, this merge is to keep code consist. 
Merge internal change: 127449992
https://codereview.chromium.org/2164483003

Convert callers of ProofSource::GetProof to use async interface (3/N)
This change converts the callpath
QuicCryptoServerConfig::EvaluateClientHello -> ProofSource::GetProof to
use the async version of the latter.
relnote: Converts one quic codepath to an async version of the same
functionality.  No functional change intended.  Protected by
reloadable_flag_enable_async_get_proof.
Merge internal change: 127330079
https://codereview.chromium.org/2153403002

relnote: Deprecate --reloadable_flag_quic_use_hash_in_scup
Merge internal change: 127145969
https://codereview.chromium.org/2156903002

relnote: Correctly use the ServerSessionHelper (aka the Dispatcher) to generate
QUIC connection IDs. Protected by --reloadable_flag_quic_dispatcher_creates_id2.
Also deprecated --reloadable_flag_quic_dispatcher_creates_id which,
in hindsight, did the right thing for gfe/quic/  *sob*
Merge internal change: 127128172
https://codereview.chromium.org/2156853002/

BUG=
==========

to

==========
Landing Recent QUIC changes until 7/18/2016 11:21:53 UTC

relnote: Use QuicAlarm::Update instead of QuicAlarm::Cancel/Set pairs. Not flag
protected.
Merge internal change: 127703830
https://codereview.chromium.org/2166583002

relnote: Use UpdateImpl to cancel and set alarms. Guarded by
quic_change_alarms_efficiently. Chromium doesn't support EpollAlarmQueue, this
merge is to keep code consist. 
Merge internal change: 127449992
https://codereview.chromium.org/2164483003

Convert callers of ProofSource::GetProof to use async interface (3/N)
This change converts the callpath
QuicCryptoServerConfig::EvaluateClientHello -> ProofSource::GetProof to
use the async version of the latter.
relnote: Converts one quic codepath to an async version of the same
functionality.  No functional change intended.  Protected by
reloadable_flag_enable_async_get_proof.
Merge internal change: 127330079
https://codereview.chromium.org/2153403002

relnote: Deprecate --reloadable_flag_quic_use_hash_in_scup
Merge internal change: 127145969
https://codereview.chromium.org/2156903002

relnote: Correctly use the ServerSessionHelper (aka the Dispatcher) to generate
QUIC connection IDs. Protected by --reloadable_flag_quic_dispatcher_creates_id2.
Also deprecated --reloadable_flag_quic_dispatcher_creates_id which,
in hindsight, did the right thing for gfe/quic/  *sob*
Merge internal change: 127128172
https://codereview.chromium.org/2156853002/

BUG=
==========

[Zhongyi Shi, 2016-07-19 22:35:34]

On 2016/07/19 21:14:52, Ryan Hamilton wrote:
> Please update the CL description as per
> https://codereview.chromium.org/2164483003/ and also add links in the CL
> description to each chromium CL.
> 
> Also, did you run the flag flip script?

Done! Sorry for missing the flag flipping stage. Instead of creating a new cl, I
update that in patch set 2. PTAL!

[Ryan Hamilton, 2016-07-20 00:09:25]

lgtm

[Zhongyi Shi, 2016-07-20 00:10:51]

The CQ bit was checked by zhongyi@chromium.org

[commit-bot: I haz the power, 2016-07-20 00:11:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 04:36:02]

Description was changed from

==========
Landing Recent QUIC changes until 7/18/2016 11:21:53 UTC

relnote: Use QuicAlarm::Update instead of QuicAlarm::Cancel/Set pairs. Not flag
protected.
Merge internal change: 127703830
https://codereview.chromium.org/2166583002

relnote: Use UpdateImpl to cancel and set alarms. Guarded by
quic_change_alarms_efficiently. Chromium doesn't support EpollAlarmQueue, this
merge is to keep code consist. 
Merge internal change: 127449992
https://codereview.chromium.org/2164483003

Convert callers of ProofSource::GetProof to use async interface (3/N)
This change converts the callpath
QuicCryptoServerConfig::EvaluateClientHello -> ProofSource::GetProof to
use the async version of the latter.
relnote: Converts one quic codepath to an async version of the same
functionality.  No functional change intended.  Protected by
reloadable_flag_enable_async_get_proof.
Merge internal change: 127330079
https://codereview.chromium.org/2153403002

relnote: Deprecate --reloadable_flag_quic_use_hash_in_scup
Merge internal change: 127145969
https://codereview.chromium.org/2156903002

relnote: Correctly use the ServerSessionHelper (aka the Dispatcher) to generate
QUIC connection IDs. Protected by --reloadable_flag_quic_dispatcher_creates_id2.
Also deprecated --reloadable_flag_quic_dispatcher_creates_id which,
in hindsight, did the right thing for gfe/quic/  *sob*
Merge internal change: 127128172
https://codereview.chromium.org/2156853002/

BUG=
==========

to

==========
Landing Recent QUIC changes until 7/18/2016 11:21:53 UTC

relnote: Use QuicAlarm::Update instead of QuicAlarm::Cancel/Set pairs. Not flag
protected.
Merge internal change: 127703830
https://codereview.chromium.org/2166583002

relnote: Use UpdateImpl to cancel and set alarms. Guarded by
quic_change_alarms_efficiently. Chromium doesn't support EpollAlarmQueue, this
merge is to keep code consist. 
Merge internal change: 127449992
https://codereview.chromium.org/2164483003

Convert callers of ProofSource::GetProof to use async interface (3/N)
This change converts the callpath
QuicCryptoServerConfig::EvaluateClientHello -> ProofSource::GetProof to
use the async version of the latter.
relnote: Converts one quic codepath to an async version of the same
functionality.  No functional change intended.  Protected by
reloadable_flag_enable_async_get_proof.
Merge internal change: 127330079
https://codereview.chromium.org/2153403002

relnote: Deprecate --reloadable_flag_quic_use_hash_in_scup
Merge internal change: 127145969
https://codereview.chromium.org/2156903002

relnote: Correctly use the ServerSessionHelper (aka the Dispatcher) to generate
QUIC connection IDs. Protected by --reloadable_flag_quic_dispatcher_creates_id2.
Also deprecated --reloadable_flag_quic_dispatcher_creates_id which,
in hindsight, did the right thing for gfe/quic/  *sob*
Merge internal change: 127128172
https://codereview.chromium.org/2156853002/

BUG=
==========

[commit-bot: I haz the power, 2016-07-20 04:36:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-20 04:37:38]

Description was changed from

==========
Landing Recent QUIC changes until 7/18/2016 11:21:53 UTC

relnote: Use QuicAlarm::Update instead of QuicAlarm::Cancel/Set pairs. Not flag
protected.
Merge internal change: 127703830
https://codereview.chromium.org/2166583002

relnote: Use UpdateImpl to cancel and set alarms. Guarded by
quic_change_alarms_efficiently. Chromium doesn't support EpollAlarmQueue, this
merge is to keep code consist. 
Merge internal change: 127449992
https://codereview.chromium.org/2164483003

Convert callers of ProofSource::GetProof to use async interface (3/N)
This change converts the callpath
QuicCryptoServerConfig::EvaluateClientHello -> ProofSource::GetProof to
use the async version of the latter.
relnote: Converts one quic codepath to an async version of the same
functionality.  No functional change intended.  Protected by
reloadable_flag_enable_async_get_proof.
Merge internal change: 127330079
https://codereview.chromium.org/2153403002

relnote: Deprecate --reloadable_flag_quic_use_hash_in_scup
Merge internal change: 127145969
https://codereview.chromium.org/2156903002

relnote: Correctly use the ServerSessionHelper (aka the Dispatcher) to generate
QUIC connection IDs. Protected by --reloadable_flag_quic_dispatcher_creates_id2.
Also deprecated --reloadable_flag_quic_dispatcher_creates_id which,
in hindsight, did the right thing for gfe/quic/  *sob*
Merge internal change: 127128172
https://codereview.chromium.org/2156853002/

BUG=
==========

to

==========
Landing Recent QUIC changes until 7/18/2016 11:21:53 UTC

relnote: Use QuicAlarm::Update instead of QuicAlarm::Cancel/Set pairs. Not flag
protected.
Merge internal change: 127703830
https://codereview.chromium.org/2166583002

relnote: Use UpdateImpl to cancel and set alarms. Guarded by
quic_change_alarms_efficiently. Chromium doesn't support EpollAlarmQueue, this
merge is to keep code consist.
Merge internal change: 127449992
https://codereview.chromium.org/2164483003

Convert callers of ProofSource::GetProof to use async interface (3/N)
This change converts the callpath
QuicCryptoServerConfig::EvaluateClientHello -> ProofSource::GetProof to
use the async version of the latter.
relnote: Converts one quic codepath to an async version of the same
functionality.  No functional change intended.  Protected by
reloadable_flag_enable_async_get_proof.
Merge internal change: 127330079
https://codereview.chromium.org/2153403002

relnote: Deprecate --reloadable_flag_quic_use_hash_in_scup
Merge internal change: 127145969
https://codereview.chromium.org/2156903002

relnote: Correctly use the ServerSessionHelper (aka the Dispatcher) to generate
QUIC connection IDs. Protected by --reloadable_flag_quic_dispatcher_creates_id2.
Also deprecated --reloadable_flag_quic_dispatcher_creates_id which,
in hindsight, did the right thing for gfe/quic/  *sob*
Merge internal change: 127128172
https://codereview.chromium.org/2156853002/

BUG=

Committed: https://crrev.com/466daf4ddf20e4bd915d9dde2ddf9822be92b4f5
Cr-Commit-Position: refs/heads/master@{#406492}
==========

[commit-bot: I haz the power, 2016-07-20 04:37:38]

Patchset 2 (id:??) landed as
https://crrev.com/466daf4ddf20e4bd915d9dde2ddf9822be92b4f5
Cr-Commit-Position: refs/heads/master@{#406492}