Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 215823002: Put the squashing layer underneath the ancestor clipping layer if present. (Closed)

Created:
6 years, 9 months ago by chrishtr
Modified:
6 years, 8 months ago
Reviewers:
Ian Vollick, hartmanng
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Put the squashing layer underneath the ancestor clipping layer if present. Previously, this was the case for m_graphicsLayer but not m_squashingLayer. Since they now are guaranteed to have the same clipping ancestor, this is both safe and correct. BUG=336563 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170348

Patch Set 1 #

Patch Set 2 : Added test. #

Patch Set 3 : Avoid squashing containment layer if clipping is present. #

Patch Set 4 : Added comments. #

Patch Set 5 : Fix. #

Patch Set 6 : Fix xor. #

Patch Set 7 : Fixed cras. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -16 lines) Patch
A LayoutTests/compositing/squashing/overflow-scroll-grandchildren.html View 1 1 chunk +62 lines, -0 lines 0 comments Download
A LayoutTests/compositing/squashing/overflow-scroll-grandchildren-expected.html View 1 1 chunk +57 lines, -0 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.h View 1 2 3 1 chunk +14 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 2 3 4 5 6 3 chunks +19 lines, -15 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
chrishtr
6 years, 9 months ago (2014-03-27 23:41:44 UTC) #1
Ian Vollick
On 2014/03/27 23:41:44, chrishtr wrote: Can we avoid creating the squashing containment layer if we've ...
6 years, 9 months ago (2014-03-27 23:48:37 UTC) #2
chrishtr
I think so. Will make that change.
6 years, 9 months ago (2014-03-27 23:53:21 UTC) #3
chrishtr
Done. PTAL.
6 years, 9 months ago (2014-03-28 00:38:17 UTC) #4
Ian Vollick
On 2014/03/28 00:38:17, chrishtr wrote: > Done. PTAL. LGTM, but I don't think that the ...
6 years, 9 months ago (2014-03-28 01:06:39 UTC) #5
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 9 months ago (2014-03-28 01:09:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/215823002/100001
6 years, 9 months ago (2014-03-28 01:09:27 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 01:23:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-28 01:23:07 UTC) #9
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 8 months ago (2014-03-28 17:06:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/215823002/120001
6 years, 8 months ago (2014-03-28 17:06:36 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-28 18:08:34 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-03-28 18:08:34 UTC) #13
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 8 months ago (2014-03-28 18:18:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/215823002/120001
6 years, 8 months ago (2014-03-28 18:18:20 UTC) #15
commit-bot: I haz the power
Change committed as 170348
6 years, 8 months ago (2014-03-28 19:01:35 UTC) #16
Ian Vollick
6 years, 8 months ago (2014-03-29 09:35:12 UTC) #17
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/218313002/ by vollick@chromium.org.

The reason for reverting is: This appears to have unexpected effects on
rendering. Bits of gmail are missing for example..

Powered by Google App Engine
This is Rietveld 408576698