fix #603, support mock objects

fix #603, support mock objects

if noSuchMethod is used to implement an abstract member, this will be detected and appropriate code will be generated.

R=leafp@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/b77003940f96fb772995016d9ee9c3204f8f5e78

[Jennifer Messerly, 2016-07-18 22:17:58]

jmesserly@google.com changed reviewers:
+ leafp@google.com

[Leaf, 2016-07-18 23:06:07]

lgtm, thanks!

https://codereview.chromium.org/2158173003/diff/1/lib/src/compiler/code_gener...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2158173003/diff/1/lib/src/compiler/code_gener...
lib/src/compiler/code_generator.dart:1377: Iterable<JS.Method>
_implementMockInterfaces(InterfaceType type) {
I don't think this is worth worrying about now, but I think this will generate
redundant stubs if you have multiple levels of subclassing won't it?  I don't
imagine that's extremely common though.  Maybe a TODO?

https://codereview.chromium.org/2158173003/diff/1/lib/src/compiler/code_gener...
lib/src/compiler/code_generator.dart:1462: // methods, up through the class
hierarchy.
ouch.

https://codereview.chromium.org/2158173003/diff/1/test/codegen_expected/langu...
File test/codegen_expected/language/no_such_method_native_test.js (right):

https://codereview.chromium.org/2158173003/diff/1/test/codegen_expected/langu...
test/codegen_expected/language/no_such_method_native_test.js:1:
dart_library.library('language/no_such_method_native_test', null, /* Imports */[
Is the baseline for this patch set out of date?  I see a non-empty checked in
verion of this .js file in the codegen_expect directory on master.

[Jennifer Messerly, 2016-07-19 20:23:55]

Thanks Leaf! landing with your suggestions :)

https://codereview.chromium.org/2158173003/diff/1/lib/src/compiler/code_gener...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2158173003/diff/1/lib/src/compiler/code_gener...
lib/src/compiler/code_generator.dart:1377: Iterable<JS.Method>
_implementMockInterfaces(InterfaceType type) {
On 2016/07/18 23:06:06, Leaf wrote:
> I don't think this is worth worrying about now, but I think this will generate
> redundant stubs if you have multiple levels of subclassing won't it?  I don't
> imagine that's extremely common though.  Maybe a TODO?

Eeeep. Good point. I added a TODO and moar tests

https://codereview.chromium.org/2158173003/diff/1/lib/src/compiler/code_gener...
lib/src/compiler/code_generator.dart:1462: // methods, up through the class
hierarchy.
On 2016/07/18 23:06:07, Leaf wrote:
> ouch.

yeah. called multiple times too, just in this visitor! when you consider full
resolution the amount of lookUpMethod is huge. at some point I've wanted to try
radical simplification/optimization experiment but never got around to it :|

[Jennifer Messerly, 2016-07-19 20:24:04]

Description was changed from

==========
fix #603, support mock objects

if noSuchMethod is used to implement an abstract member, this will be detected
and appropriate code will be generated.
==========

to

==========
fix #603, support mock objects

if noSuchMethod is used to implement an abstract member, this will be detected
and appropriate code will be generated.

R=leafp@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/b77003940f96fb772995016d9ee9...
==========

[Jennifer Messerly, 2016-07-19 20:24:05]

Committed patchset #2 (id:20001) manually as
b77003940f96fb772995016d9ee9c3204f8f5e78 (presubmit successful).