Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2158173002:
Max start velocity should be greater than zero. (Closed)
|
Created:
4 years, 5 months ago by sahel Modified:
4 years, 5 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
chromium-reviews, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMax start velocity should be greater than zero.
Check in event_sender.cc to avoid sending flingsgesturestart events with velocity of zero.
BUG=628525
Committed: https://crrev.com/42a50bbf81e1e75e5b734c2523c96656ad42fc8c
Cr-Commit-Position: refs/heads/master@{#407231}
Patch Set 1 #Patch Set 2 : the gesture fling start with zero velocity fixed in the layout test. #
Messages
Total messages: 26 (17 generated)
sahel@chromium.org changed reviewers: + abarth@chromium.org
Description was changed from ========== Max start velocity should be greater than zero. Check in event_sender.cc to avoid sending flingsgesturestart events with velocity of zero. BUG=628525 ========== to ========== Max start velocity should be greater than zero. Check in event_sender.cc to avoid sending flingsgesturestart events with velocity of zero. BUG=628525 ==========
sahel@chromium.org changed reviewers: - abarth@chromium.org
sahel@chromium.org changed reviewers: + blundell@chromium.org
please, review this patch.
blundell@chromium.org changed reviewers: + jochen@chromium.org - blundell@chromium.org
blundell -> jochen
lgtm
The CQ bit was checked by sahel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2016/07/21 08:29:57, jochen wrote: > lgtm I had to change the gestureFlingStart call for the failing layout test.
The CQ bit was checked by sahel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sahel@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org Link to the patchset: https://codereview.chromium.org/2158173002/#ps20001 (title: "the gesture fling start with zero velocity fixed in the layout test.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Max start velocity should be greater than zero. Check in event_sender.cc to avoid sending flingsgesturestart events with velocity of zero. BUG=628525 ========== to ========== Max start velocity should be greater than zero. Check in event_sender.cc to avoid sending flingsgesturestart events with velocity of zero. BUG=628525 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Max start velocity should be greater than zero. Check in event_sender.cc to avoid sending flingsgesturestart events with velocity of zero. BUG=628525 ========== to ========== Max start velocity should be greater than zero. Check in event_sender.cc to avoid sending flingsgesturestart events with velocity of zero. BUG=628525 Committed: https://crrev.com/42a50bbf81e1e75e5b734c2523c96656ad42fc8c Cr-Commit-Position: refs/heads/master@{#407231} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/42a50bbf81e1e75e5b734c2523c96656ad42fc8c Cr-Commit-Position: refs/heads/master@{#407231} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
