Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2158103002: Remove the Win10 specific text for the default browser prompt (Closed)

Created:
4 years, 5 months ago by Patrick Monette
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the Win10 specific text for the default browser prompt Experimenting with a different text did not yield any positive results. BUG=589128 Committed: https://crrev.com/98663478f26ab7183f9348f13cf619c0b1a63cb1 Cr-Commit-Position: refs/heads/master@{#406089}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -17 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/startup/default_browser_infobar_delegate.cc View 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Patrick Monette
PTAL grt@ for chrome/app pkasting@ for chrome/browser/ui
4 years, 5 months ago (2016-07-18 18:17:23 UTC) #2
grt (UTC plus 2)
lgtm
4 years, 5 months ago (2016-07-18 19:44:44 UTC) #4
Peter Kasting
LGTM
4 years, 5 months ago (2016-07-18 19:49:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158103002/1
4 years, 5 months ago (2016-07-18 19:54:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 20:59:19 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 21:00:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98663478f26ab7183f9348f13cf619c0b1a63cb1
Cr-Commit-Position: refs/heads/master@{#406089}

Powered by Google App Engine
This is Rietveld 408576698