Issue 21581003: Drop [IsIndex] attribute from CharacterData API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21581003: Drop [IsIndex] attribute from CharacterData API (Closed)

Created:
7 years, 4 months ago by do-not-use

Modified:
7 years, 4 months ago

Reviewers:
haraken, tkent, arv (Not doing code reviews)

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, do-not-use, lgombos

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Drop [IsIndex] attribute from CharacterData API The DOM level3 specification used to require the following CharacterData operations to throw an IndexSizeError if the offset was negative: substringData(), deleteData(), insertData() and replaceData(). This is however not the case anymore in DOM4: http://dom.spec.whatwg.org/#concept-cd-substring http://dom.spec.whatwg.org/#concept-cd-replace We should now only throw an IndexSizeError if the offset is greater than the data length. We can therefore drop the [IsIndex] attribute and let the bindings convert the number to an unsigned long as per the Web IDL specification: http://dev.w3.org/2006/webapi/WebIDL/#es-unsigned-long This behavior is consistent with both IE10 and Firefox. BUG=237739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155423

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -7 lines)			Patch
M	LayoutTests/fast/dom/characterdata-api-arguments.html	View	3 chunks	+15 lines, -3 lines	0 comments	Download
M	LayoutTests/fast/dom/characterdata-api-arguments-expected.txt	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	Source/core/dom/CharacterData.idl	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/21581003/1

7 years, 4 months ago (2013-08-02 05:19:55 UTC) #5

Message was sent while issue was closed.

Change committed as 155423