Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2158073002: Revert of [DevTools] Always report encodedDataLength in Network.ResponseReceived. (Closed)

Created:
4 years, 5 months ago by dgozman
Modified:
4 years, 5 months ago
Reviewers:
allada, mmenke
CC:
chromium-reviews, caseq+blink_chromium.org, pfeldman+blink_chromium.org, jam, Randy Smith (Not in Mondays), lushnikov+blink_chromium.org, blink-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, loading-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Always report encodedDataLength in Network.ResponseReceived. (patchset #1 id:1 of https://codereview.chromium.org/2101073002/ ) Reason for revert: Decided to try another approach, see discussion in issue 622018 Original issue's description: > [DevTools] Always report encodedDataLength in Network.ResponseReceived. > > Currently, we only send encodedDataLength for redirects. However, we already know how much we read when sending ResponseReceived. This will improve reporting for failed requests, as they don't get loadingFinished with full encodedDataLength. > > BUG=622018 > > Committed: https://crrev.com/00f8f6c17d27799700974e599d6003b7f376071c > Cr-Commit-Position: refs/heads/master@{#402543} TBR=allada@chromium.org,mmenke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=622018 Committed: https://crrev.com/28070b59ef30ffeaefa8e9d0364726339e60ee12 Cr-Commit-Position: refs/heads/master@{#406061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/browser/loader/async_resource_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/loader/netlog_observer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
dgozman
Created Revert of [DevTools] Always report encodedDataLength in Network.ResponseReceived.
4 years, 5 months ago (2016-07-18 17:58:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158073002/1
4 years, 5 months ago (2016-07-18 17:58:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 19:28:08 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 19:31:05 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28070b59ef30ffeaefa8e9d0364726339e60ee12
Cr-Commit-Position: refs/heads/master@{#406061}

Powered by Google App Engine
This is Rietveld 408576698