Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2158063002: DevTools: generate_protocol_externs.js should accept both protocol files as arguments (Closed)

Created:
4 years, 5 months ago by lushnikov
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: generate_protocol_externs.js should accept both protocol files as arguments Since protocol split, the generate_protocol_externs.js CLI has to accept both protocol files as input. BUG=none R=dgozman Committed: https://crrev.com/7b4239d4b88767a6372a7694cfa0829495e25c5f Cr-Commit-Position: refs/heads/master@{#406052}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/scripts/generate_protocol_externs.py View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
lushnikov
please, take a look
4 years, 5 months ago (2016-07-18 17:39:21 UTC) #1
dgozman
lgtm
4 years, 5 months ago (2016-07-18 18:04:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158063002/1
4 years, 5 months ago (2016-07-18 18:11:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 19:04:15 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 19:04:35 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 19:05:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b4239d4b88767a6372a7694cfa0829495e25c5f
Cr-Commit-Position: refs/heads/master@{#406052}

Powered by Google App Engine
This is Rietveld 408576698