Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 2158053002: Use "-Os" for Android or IOS in "optimize_max" config (Closed)

Created:
4 years, 5 months ago by huapengl
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, sdefresne
CC:
chromium-reviews, sdefresne
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use "-Os" for Android or IOS in "optimize_max" config Using "-Os" would benefit both Android and IOS build, because "-Os" does "-O2" optimizations and code size improvement. libchrome.so drops from 44MB to 42 MB. ChromePublic.apk drops from 47 MB to 45 MB. BUG=621335 Committed: https://crrev.com/2bb3c4f7a7c7632afe1b63a19d49daa61bbfc37b Cr-Commit-Position: refs/heads/master@{#406304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
huapengl
Hi, Can you take a look at this CL? Thanks
4 years, 5 months ago (2016-07-18 17:41:01 UTC) #2
Dirk Pranke
lgtm. thanks for fixing this! That's not so good, that "optimize_max" was actually worse than ...
4 years, 5 months ago (2016-07-18 22:59:18 UTC) #3
agrieve
On 2016/07/18 22:59:18, Dirk Pranke wrote: > lgtm. thanks for fixing this! > > That's ...
4 years, 5 months ago (2016-07-19 00:09:37 UTC) #4
sdefresne
Thank you!
4 years, 5 months ago (2016-07-19 08:25:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158053002/1
4 years, 5 months ago (2016-07-19 16:02:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 17:19:30 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2bb3c4f7a7c7632afe1b63a19d49daa61bbfc37b Cr-Commit-Position: refs/heads/master@{#406304}
4 years, 5 months ago (2016-07-19 17:21:56 UTC) #11
huapengl
4 years, 5 months ago (2016-07-20 15:41:44 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2164973002/ by huapengl@amazon.com.

The reason for reverting is: 8.1% regression in speedometer at 406285:406306

https://bugs.chromium.org/p/chromium/issues/detail?id=629798#c4.

Powered by Google App Engine
This is Rietveld 408576698