core/fxge/win32/fx_win32_print.cpp - Issue 2158023002: Pdfium: Fix fonts leaking on ClosePage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxge/win32/fx_win32_print.cpp

Issue 2158023002: Pdfium: Fix fonts leaking on ClosePage. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Fix leaks on PageClose Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxge/win32/fx_win32_print.cpp

diff --git a/core/fxge/win32/fx_win32_print.cpp b/core/fxge/win32/fx_win32_print.cpp

index 6b9c2cce351bde9f6599fd5275da2a05524f9417..13d474b27fbcb18ccac6083787a43c26127ba987 100644

--- a/core/fxge/win32/fx_win32_print.cpp

+++ b/core/fxge/win32/fx_win32_print.cpp

@@ -15,7 +15,6 @@

#include "core/fxge/dib/dib_int.h"

#include "core/fxge/ge/fx_text_int.h"

#include "core/fxge/include/fx_freetype.h"

-#include "core/fxge/include/cfx_fontcache.h"

#include "core/fxge/include/cfx_renderdevice.h"

#include "core/fxge/include/cfx_windowsdevice.h"

#include "core/fxge/win32/win32_int.h"

@@ -199,7 +198,6 @@ FX_BOOL CGdiPrinterDriver::StartDIBits(const CFX_DIBSource* pSource,

FX_BOOL CGdiPrinterDriver::DrawDeviceText(int nChars,

const FXTEXT_CHARPOS* pCharPos,

CFX_Font* pFont,

- CFX_FontCache* pCache,

const CFX_Matrix* pObject2Device,

FX_FLOAT font_size,

uint32_t color) {