xfa/fxgraphics/cfx_graphics.cpp - Issue 2158023002: Pdfium: Fix fonts leaking on ClosePage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxgraphics/cfx_graphics.cpp

Issue 2158023002: Pdfium: Fix fonts leaking on ClosePage. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Fix xfa tests. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxgraphics/cfx_graphics.cpp

diff --git a/xfa/fxgraphics/cfx_graphics.cpp b/xfa/fxgraphics/cfx_graphics.cpp

index 068ed015f466e45bba6a61a13140f54a5ce7805c..b9f8287ae437dd0f7f2dd04d54a5247388b76a78 100644

--- a/xfa/fxgraphics/cfx_graphics.cpp

+++ b/xfa/fxgraphics/cfx_graphics.cpp

@@ -1294,9 +1294,8 @@ FWL_Error CFX_Graphics::RenderDeviceShowText(const CFX_PointF& point,

m.Concat(*matrix);

}

FX_BOOL result = m_renderDevice->DrawNormalText(

- length, charPos, m_info.font, CFX_GEModule::Get()->GetFontCache(),

- -m_info.fontSize * m_info.fontHScale, &m, m_info.fillColor->m_info.argb,

- FXTEXT_CLEARTYPE);

+ length, charPos, m_info.font, -m_info.fontSize * m_info.fontHScale, &m,

+ m_info.fillColor->m_info.argb, FXTEXT_CLEARTYPE);

if (!result)

return FWL_Error::Indefinite;

FX_Free(charPos);