Pdfium: Fix fonts leaking on ClosePage.

core/fxge/ge/cfx_font.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fxge/include/fx_font.h"
 
 #include "core/fpdfapi/fpdf_font/include/cpdf_font.h"
 #include "core/fxge/ge/fx_text_int.h"
+#include "core/fxge/include/cfx_facecache.h"
+#include "core/fxge/include/cfx_fontcache.h"
 #include "core/fxge/include/cfx_fontmgr.h"
 #include "core/fxge/include/cfx_gemodule.h"
 #include "core/fxge/include/cfx_pathdata.h"
 #include "core/fxge/include/cfx_substfont.h"
 #include "core/fxge/include/fx_freetype.h"
 
 #define EM_ADJUST(em, a) (em == 0 ? (a) : (a)*1000 / em)
 
 namespace {
 
@@ skipping 196 matching lines @@
     59, 59, 59, 59, 59, 59, 59, 60, 60, 60, 60, 60, 60, 60, 60,
 };
 
 CFX_Font::CFX_Font()
     :
 #ifdef PDF_ENABLE_XFA
       m_bShallowCopy(false),
       m_pOwnedStream(nullptr),
 #endif  // PDF_ENABLE_XFA
       m_Face(nullptr),
+      m_FaceCache(nullptr),
+      m_FontCache(new CFX_FontCacheItem(this)),
       m_pFontData(nullptr),
       m_pGsubData(nullptr),
       m_dwSize(0),
 #if _FXM_PLATFORM_ == _FXM_PLATFORM_APPLE_
       m_pPlatformFont(nullptr),
 #endif
       m_bEmbedded(FALSE),
       m_bVertical(FALSE) {
 }
 
@@ skipping 18 matching lines @@
   m_Face = pFont->m_Face;
   m_bEmbedded = pFont->m_bEmbedded;
   m_bVertical = pFont->m_bVertical;
   m_dwSize = pFont->m_dwSize;
   m_pFontData = pFont->m_pFontData;
   m_pGsubData = pFont->m_pGsubData;
 #if _FXM_PLATFORM_ == _FXM_PLATFORM_APPLE_
   m_pPlatformFont = pFont->m_pPlatformFont;
 #endif
   m_pOwnedStream = pFont->m_pOwnedStream;
+  m_FaceCache = pFont->GetFaceCache();

[dsinclair, 2016/09/14 17:51:50]

What about m_FontCache?

[snake, 2016/09/14 19:06:29]

m_FontCache it is just wrapper (which will never changed for CFX_Font instance),
which translate calls to m_FaceCache.
It is allocated once in constructor.
UPD: I did remove wrapper "m_FontCache"

   return TRUE;
 }
 #endif  // PDF_ENABLE_XFA
 
 CFX_Font::~CFX_Font() {
 #ifdef PDF_ENABLE_XFA
   if (m_bShallowCopy) {
     m_OtfFontData.DetachBuffer();
     return;
   }
 #endif  // PDF_ENABLE_XFA
   if (m_Face) {
 #ifndef PDF_ENABLE_XFA
     if (FXFT_Get_Face_External_Stream(m_Face)) {
       FXFT_Clear_Face_External_Stream(m_Face);
     }
 #endif  // PDF_ENABLE_XFA
-    if (m_bEmbedded)
-      DeleteFace();
-    else
-      CFX_GEModule::Get()->GetFontMgr()->ReleaseFace(m_Face);
+    DeleteFace();
   }
 #ifdef PDF_ENABLE_XFA
   delete m_pOwnedStream;
 #endif  // PDF_ENABLE_XFA
   FX_Free(m_pGsubData);
 #if _FXM_PLATFORM_ == _FXM_PLATFORM_APPLE_ && !defined _SKIA_SUPPORT_
   ReleasePlatformResource();
 #endif
 }
 
 void CFX_Font::DeleteFace() {
-  FXFT_Done_Face(m_Face);
+  ClearFaceCache();
+  if (m_bEmbedded) {
+    FXFT_Done_Face(m_Face);
+  } else {
+    CFX_GEModule::Get()->GetFontMgr()->ReleaseFace(m_Face);
+  }
   m_Face = nullptr;
 }
 
 void CFX_Font::LoadSubst(const CFX_ByteString& face_name,
                          FX_BOOL bTrueType,
                          uint32_t flags,
                          int weight,
                          int italic_angle,
                          int CharsetCP,
                          FX_BOOL bVertical) {
@@ skipping 222 matching lines @@
 }
 
 int CFX_Font::GetMaxAdvanceWidth() const {
   if (!m_Face)
     return 0;
 
   return EM_ADJUST(FXFT_Get_Face_UnitsPerEM(m_Face),
                    FXFT_Get_Face_MaxAdvanceWidth(m_Face));
 }
 
+CFX_FaceCache* CFX_Font::GetFaceCache() const {
+  if (!m_FaceCache) {
+    m_FaceCache = CFX_GEModule::Get()->GetFontCache()->GetCachedFace(
+        const_cast<CFX_Font*>(this));

[dsinclair, 2016/09/14 17:51:50]

We should remove the const from the signature instead of doing const_cast

[snake, 2016/09/14 19:06:29]

Done

+  }
+  return m_FaceCache;
+}
+
+void CFX_Font::ClearFaceCache() {
+  if (!m_FaceCache)
+    return;
+  CFX_GEModule::Get()->GetFontCache()->ReleaseCachedFace(this);
+  m_FaceCache = nullptr;
+}
+
 int CFX_Font::GetULPos() const {
   if (!m_Face)
     return 0;
 
   return EM_ADJUST(FXFT_Get_Face_UnitsPerEM(m_Face),
                    FXFT_Get_Face_UnderLinePosition(m_Face));
 }
 
 int CFX_Font::GetULthickness() const {
   if (!m_Face)
@@ skipping 105 matching lines @@
   params.m_pPoints = pPath->GetPoints();
   params.m_CurX = params.m_CurY = 0;
   params.m_CoordUnit = 64 * 64.0;
   FXFT_Outline_Decompose(FXFT_Get_Glyph_Outline(m_Face), &funcs, &params);
   Outline_CheckEmptyContour(&params);
   pPath->TrimPoints(params.m_PointCount);
   if (params.m_PointCount)
     pPath->GetPoints()[params.m_PointCount - 1].m_Flag |= FXPT_CLOSEFIGURE;
   return pPath;
 }
+
+CFX_FontCacheItem::CFX_FontCacheItem(CFX_Font* font) : m_Font(font) {}
+
+CFX_FontCacheItem::~CFX_FontCacheItem() {}
+
+const CFX_GlyphBitmap* CFX_FontCacheItem::LoadGlyphBitmap(
+    uint32_t glyph_index,
+    FX_BOOL bFontStyle,
+    const CFX_Matrix* pMatrix,
+    int dest_width,
+    int anti_alias,
+    int& text_flags) const {
+  return m_Font->GetFaceCache()->LoadGlyphBitmap(
+      m_Font, glyph_index, bFontStyle, pMatrix, dest_width, anti_alias,
+      text_flags);
+}
+
+const CFX_PathData* CFX_FontCacheItem::LoadGlyphPath(uint32_t glyph_index,
+                                                     int dest_width) const {
+  return m_Font->GetFaceCache()->LoadGlyphPath(m_Font, glyph_index, dest_width);
+}
+
+#ifdef _SKIA_SUPPORT_
+CFX_TypeFace* CFX_FontCacheItem::GetDeviceCache() const {
+  return m_Font->GetFaceCache()->GetDeviceCache(m_Font);
+}
+#endif