Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2158003003: Revert of Use common_custom_types instead of remapping base::ListValue in SafeJsonParser (Closed)

Created:
4 years, 5 months ago by alph
Modified:
4 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blundell+watchlist_chromium.org, chromium-reviews, darin (slow to review), droger+watchlist_chromium.org, qsr+mojo_chromium.org, sdefresne+watchlist_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use common_custom_types instead of remapping base::ListValue in SafeJsonParser (patchset #9 id:180001 of https://codereview.chromium.org/2121793002/ ) Reason for revert: Broke compilation https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20ChromeOS%20MSan%20Builder/builds/17876 Original issue's description: > Use common_custom_types instead of remapping base::ListValue in SafeJsonParser > > Committed: https://crrev.com/623ad061886068c1ce323e7a499b91f61918c001 > Cr-Commit-Position: refs/heads/master@{#406139} TBR=jochen@chromium.org,bauerb@chromium.org,dcheng@chromium.org,amistry@chromium.org,pmonette@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/fddf9164a7d39a6f71b2a99d33cf1ff56d74f552 Cr-Commit-Position: refs/heads/master@{#406159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M components/safe_json.gypi View 1 chunk +5 lines, -6 lines 0 comments Download
M components/safe_json/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/safe_json/public/interfaces/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M components/safe_json/public/interfaces/safe_json.mojom View 1 chunk +3 lines, -2 lines 0 comments Download
A components/safe_json/public/interfaces/safe_json.typemap View 1 chunk +9 lines, -0 lines 0 comments Download
M components/typemaps.gni View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
alph
Created Revert of Use common_custom_types instead of remapping base::ListValue in SafeJsonParser
4 years, 5 months ago (2016-07-19 00:30:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158003003/1
4 years, 5 months ago (2016-07-19 00:33:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 00:35:12 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 00:35:43 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 00:37:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fddf9164a7d39a6f71b2a99d33cf1ff56d74f552
Cr-Commit-Position: refs/heads/master@{#406159}

Powered by Google App Engine
This is Rietveld 408576698