Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2157963002: Improve grammar in some comments. (Closed)

Created:
4 years, 5 months ago by Nico
Modified:
4 years, 5 months ago
Reviewers:
haraken, brettw
CC:
chromium-reviews, sadrul, zea+watch_chromium.org, johnme+watch_chromium.org, eae+blinkwatch, gavinp+memory_chromium.org, dcheng, leviw+renderwatch, apavlov+blink_chromium.org, arv+watch_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, szager+layoutwatch_chromium.org, mlamouri+watch-notifications_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, blink-reviews, kalyank, jbudorick+watch_chromium.org, jennb, zoltan1, Peter Beverloo, blink-reviews-layout_chromium.org, caseq+blink_chromium.org, jianli, feature-media-reviews_chromium.org, lushnikov+blink_chromium.org, oshima+watch_chromium.org, kinuko+cache_chromium.org, tfarina, pdr+renderingwatchlist_chromium.org, Dmitry Titov, pfeldman+blink_chromium.org, mikecase+watch_chromium.org, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve grammar in some comments. git grep'd for "more then", "less then", "greater then". (Interestingly, no hits for "fewer then".) BUG=none NOPRESUBMIT=true CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e5b5786ad5d329fbfc39a32896ad4686a8eda112 Cr-Commit-Position: refs/heads/master@{#406059}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : maxiumum #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -41 lines) Patch
M ash/common/system/tray/system_tray.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/user/tray_user_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/containers/small_map.h View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/memory_pressure_monitor_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/memory_pressure_monitor_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/user_images_grid.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/connector_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/geolocation/simple_geolocation_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/timezone/timezone_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gcm/engine/mcs_client.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/cookies/cookie_store.h View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/tools/balsa/balsa_headers_token_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/cardboard/Photosphere.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-duration.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-search-reveals-messages.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles/resources/styles-update-links-2.css View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/jquery/resources/test/unit/manipulation.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/carto.net/resources/comboBox.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/carto.net/resources/selectionList.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutCounter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/formatter_worker/CSSRuleParser.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/forwarder2/socket.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_popup_collection.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (11 generated)
Nico
sorry :-/
4 years, 5 months ago (2016-07-18 16:46:59 UTC) #6
brettw
rs lgtm
4 years, 5 months ago (2016-07-18 17:48:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2157963002/30001
4 years, 5 months ago (2016-07-18 18:58:58 UTC) #9
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-18 18:59:01 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/219876)
4 years, 5 months ago (2016-07-18 19:14:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2157963002/30001
4 years, 5 months ago (2016-07-18 19:21:02 UTC) #15
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-18 19:21:05 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:30001)
4 years, 5 months ago (2016-07-18 19:23:39 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 19:23:44 UTC) #19
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/e5b5786ad5d329fbfc39a32896ad4686a8eda112 Cr-Commit-Position: refs/heads/master@{#406059}
4 years, 5 months ago (2016-07-18 19:26:42 UTC) #21
haraken
4 years, 5 months ago (2016-07-18 22:46:50 UTC) #22
Message was sent while issue was closed.
WebKit LGTM

Powered by Google App Engine
This is Rietveld 408576698