third_party/WebKit/LayoutTests/fast/canvas/canvas-imageSmoothingQuality.html - Issue 2157953002: Change filter quality when scaling-down in drawImage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/canvas/canvas-imageSmoothingQuality.html

Issue 2157953002: Change filter quality when scaling-down in drawImage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: no need to change Image::draw API Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp » ('j') | third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/canvas/canvas-imageSmoothingQuality.html

diff --git a/third_party/WebKit/LayoutTests/fast/canvas/canvas-imageSmoothingQuality.html b/third_party/WebKit/LayoutTests/fast/canvas/canvas-imageSmoothingQuality.html

index 6e5226570b195d14d593a8a813d49a867f75c0f4..ca853e8aafa41cc9f9a855d3612711d6b5694769 100644

--- a/third_party/WebKit/LayoutTests/fast/canvas/canvas-imageSmoothingQuality.html

+++ b/third_party/WebKit/LayoutTests/fast/canvas/canvas-imageSmoothingQuality.html

@@ -85,7 +85,7 @@ shouldBe("mediumData", "highData");

shouldNotBe("lowData", "highData");

debug("");

-shouldBeGreaterThan("sampleAlpha(noFilterData)", "sampleAlpha(lowData)");

+shouldBe("sampleAlpha(noFilterData)", "sampleAlpha(lowData)");

xidachen 2016/07/18 18:28:08 Would this test enough? should I add a new test do

shouldBeGreaterThan("sampleAlpha(lowData)", "sampleAlpha(mediumData)");

// Skia uses mipmaps when downscaling, for both high and medium quality

shouldBe("sampleAlpha(mediumData)", "sampleAlpha(highData)");