Issue 21579003: Remove instructions and infrastructure related to IDEFs that is now obsolete (and was never turned …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21579003: Remove instructions and infrastructure related to IDEFs that is now obsolete (and was never turned … (Closed)

Created:
7 years, 4 months ago by titzer

Modified:
7 years, 4 months ago

Reviewers:
Michael Starzinger, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove instructions and infrastructure related to IDEFs that is now obsolete (and was never turned on). The new bounds check elimination phase doesn't make use of these features, as they were the first parts of the previous approach which was never completed. BUG= R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16027

Patch Set 1 #

Patch Set 2 : Remove TODO. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -859 lines)			Patch
M	src/arm/lithium-arm.cc	View		1 chunk	+0 lines, -11 lines	0 comments	Download
M	src/flag-definitions.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/hydrogen.cc	View	1	2 chunks	+2 lines, -47 lines	0 comments	Download
M	src/hydrogen-instructions.h	View		20 chunks	+4 lines, -405 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		8 chunks	+0 lines, -362 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		1 chunk	+0 lines, -11 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View		1 chunk	+0 lines, -11 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View		1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

titzer

7 years, 4 months ago (2013-08-02 11:17:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r16027 (presubmit successful).

Expand Messages | Collapse Messages