Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: third_party/WebKit/Source/modules/plugins/DOMPlugin.cpp

Issue 2157883002: Cache the mimeTypes and plugins DOM objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated after dry run. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/plugins/DOMPlugin.cpp
diff --git a/third_party/WebKit/Source/modules/plugins/DOMPlugin.cpp b/third_party/WebKit/Source/modules/plugins/DOMPlugin.cpp
index 02d8b7c12b64632b4ae5eea3e28e384070191c55..0721fca8b3e46cba621670c5014207957c2f8b1d 100644
--- a/third_party/WebKit/Source/modules/plugins/DOMPlugin.cpp
+++ b/third_party/WebKit/Source/modules/plugins/DOMPlugin.cpp
@@ -18,7 +18,11 @@
#include "modules/plugins/DOMPlugin.h"
+#include "core/frame/LocalDOMWindow.h"
+#include "modules/plugins/DOMMimeTypeArray.h"
+#include "modules/plugins/NavigatorPlugins.h"
#include "platform/plugins/PluginData.h"
+
#include "wtf/text/AtomicString.h"
namespace blink {
@@ -69,7 +73,7 @@ DOMMimeType* DOMPlugin::item(unsigned index)
const Vector<MimeClassInfo>& mimes = m_pluginData->mimes();
for (unsigned i = 0; i < mimes.size(); ++i) {
if (mimes[i] == mime && m_pluginData->mimePluginIndices()[i] == m_index)
- return DOMMimeType::create(m_pluginData.get(), frame(), i);
+ return NavigatorPlugins::mimeTypes(*frame()->domWindow()->navigator())->getMimeType(i);
}
return nullptr;
}
@@ -79,7 +83,7 @@ DOMMimeType* DOMPlugin::namedItem(const AtomicString& propertyName)
const Vector<MimeClassInfo>& mimes = m_pluginData->mimes();
for (unsigned i = 0; i < mimes.size(); ++i) {
if (mimes[i].type == propertyName)
- return DOMMimeType::create(m_pluginData.get(), frame(), i);
+ return NavigatorPlugins::mimeTypes(*frame()->domWindow()->navigator())->getMimeType(i);
}
return nullptr;
}

Powered by Google App Engine
This is Rietveld 408576698