third_party/WebKit/Source/modules/plugins/DOMMimeType.cpp - Issue 2157883002: Cache the mimeTypes and plugins DOM objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/plugins/DOMMimeType.cpp

Issue 2157883002: Cache the mimeTypes and plugins DOM objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated after dry run. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/plugins/DOMMimeType.cpp

diff --git a/third_party/WebKit/Source/modules/plugins/DOMMimeType.cpp b/third_party/WebKit/Source/modules/plugins/DOMMimeType.cpp

index 3b6e5223be120e772cf10e55feefb740b192a7a0..5ab55194dd1db6bdc7c4a32daa4a38661bfa2e59 100644

--- a/third_party/WebKit/Source/modules/plugins/DOMMimeType.cpp

+++ b/third_party/WebKit/Source/modules/plugins/DOMMimeType.cpp

@@ -18,10 +18,13 @@

#include "modules/plugins/DOMMimeType.h"

+#include "core/frame/LocalDOMWindow.h"

#include "core/frame/LocalFrame.h"

#include "core/loader/FrameLoader.h"

#include "core/page/Page.h"

#include "modules/plugins/DOMPlugin.h"

+#include "modules/plugins/DOMPluginArray.h"

+#include "modules/plugins/NavigatorPlugins.h"

#include "wtf/text/StringBuilder.h"

namespace blink {

@@ -73,7 +76,7 @@ DOMPlugin* DOMMimeType::enabledPlugin() const

if (!frame() || !frame()->loader().allowPlugins(NotAboutToInstantiatePlugin))

return nullptr;

- return DOMPlugin::create(m_pluginData.get(), frame(), m_pluginData->mimePluginIndices()[m_index]);

+ return NavigatorPlugins::plugins(*frame()->domWindow()->navigator())->getPlugin(m_pluginData->mimePluginIndices()[m_index]);

}

} // namespace blink