third_party/WebKit/LayoutTests/plugins/enabledPlugin-after-iframe-detached.html - Issue 2157883002: Cache the mimeTypes and plugins DOM objects.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/plugins/enabledPlugin-after-iframe-detached.html

Issue 2157883002: Cache the mimeTypes and plugins DOM objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added new layout test, both tests use testharness.js. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/plugins/navigator-plugins-mimeTypes-comparison.html » ('j') | third_party/WebKit/LayoutTests/plugins/navigator-plugins-mimeTypes-comparison.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <div id='d'>

	5 <iframe id='test-plugin-iframe-id' src="resources/x-blink-test-plugin-iframe.htm l"></iframe>
	dominicc (has gone to gerrit) 2016/08/30 02:46:28 Be consistent about types of quotes for attributes Be consistent about types of quotes for attributes--prefer double quotes.
	6 </div>

	7 <script>

	8 async_test(function(t)
	dominicc (has gone to gerrit) 2016/08/30 02:46:28 Consider using arrow functions; they're slightly m Consider using arrow functions; they're slightly more succinct and readable. Below too. http://es6-features.org/#StatementBodies
	9 {

	10 var mimeType;

	11 document.getElementById('test-plugin-iframe-id').onload = t.step_func(functi on()

	12 {
	dominicc (has gone to gerrit) 2016/08/30 02:46:28 Put { on the previous line. A bit of Blink C++ sty Put { on the previous line. A bit of Blink C++ style is bleeding into your JavaScript.
	13 mimeType = navigator.mimeTypes['application/x-blink-test-plugin'];

	14 assert_equals(mimeType.enabledPlugin.name, 'Blink Test Plugin');

	15 document.getElementById("d").innerHTML = "";
	dominicc (has gone to gerrit) 2016/08/30 02:46:28 Be consistent with single and double quotes for st Be consistent with single and double quotes for string literals. Prefer single quotes.
	16 setTimeout(t.step_func(function() {

	17 assert_equals(mimeType.enabledPlugin.name, 'Blink Test Plugin');

	18 t.done();

	19 }, 50));
	dominicc (has gone to gerrit) 2016/08/30 02:46:28 Is there an event you can listen for, instead of a Is there an event you can listen for, instead of a timeout? If you just need to spin the event loop, use requestAnimationFrame. It's way faster. Anton Obzhirov 2016/09/01 10:46:37 Yes, it is just to get out of this loop iteration. Show quoted text On 2016/08/30 02:46:28, dominicc wrote: > Is there an event you can listen for, instead of a timeout? If you just need to > spin the event loop, use requestAnimationFrame. It's way faster. Yes, it is just to get out of this loop iteration. I could also use requestIdleCallback but requestAnimationFrame will be faster.
	20 });

	21 }, "Test enabledPlugin after iframe with the plugin is detached.");

	22 </script>

	23

OLD	NEW