content/browser/renderer_host/render_widget_host_view_base.cc - Issue 2157793002: Remove ContentViewCore::RequestTextSurroundingSelection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.cc

Issue 2157793002: Remove ContentViewCore::RequestTextSurroundingSelection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the review comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_base.h ('k') | content/public/browser/android/content_view_core.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_base.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_base.cc b/content/browser/renderer_host/render_widget_host_view_base.cc

index 8b8907e262a95b8790a6b404c8ed0ccef5bc2a1e..b9bcafc640e9a105f1cd93d2b6e7129760df01cb 100644

--- a/content/browser/renderer_host/render_widget_host_view_base.cc

+++ b/content/browser/renderer_host/render_widget_host_view_base.cc

@@ -292,13 +292,6 @@ void RenderWidgetHostViewBase::FlushInput() {

impl->FlushInput();

}

-void RenderWidgetHostViewBase::OnTextSurroundingSelectionResponse(

- const base::string16& content,

- size_t start_offset,

- size_t end_offset) {

- NOTIMPLEMENTED();

void RenderWidgetHostViewBase::ShowDisambiguationPopup(

const gfx::Rect& rect_pixels,

const SkBitmap& zoomed_bitmap) {

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_base.h ('k') | content/public/browser/android/content_view_core.h » ('j') | no next file with comments »