content/browser/renderer_host/render_widget_host_view_base.h - Issue 2157793002: Remove ContentViewCore::RequestTextSurroundingSelection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 2157793002: Remove ContentViewCore::RequestTextSurroundingSelection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the review comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_impl.cc ('K') | « content/browser/renderer_host/render_widget_host_view_android.cc ('k') | content/browser/renderer_host/render_widget_host_view_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_base.h

diff --git a/content/browser/renderer_host/render_widget_host_view_base.h b/content/browser/renderer_host/render_widget_host_view_base.h

index 0a1e01ebc6587bb1cb833e6101e5325d1b13fbf0..d6cff9524b5d96d22158766f8d84f71af4462fd6 100644

--- a/content/browser/renderer_host/render_widget_host_view_base.h

+++ b/content/browser/renderer_host/render_widget_host_view_base.h

@@ -368,12 +368,6 @@ class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,

// Gets the bounds of the window, in screen coordinates.

virtual gfx::Rect GetBoundsInRootWindow() = 0;

- // Called by the RenderFrameHost when it receives an IPC response to a

- // TextSurroundingSelectionRequest.

- virtual void OnTextSurroundingSelectionResponse(const base::string16& content,

- size_t start_offset,

- size_t end_offset);

// Called by the RenderWidgetHost when an ambiguous gesture is detected to

// show the disambiguation popup bubble.

virtual void ShowDisambiguationPopup(const gfx::Rect& rect_pixels,