Don't call RenderObject::enclosingLayer on a null pointer

Don't call RenderObject::enclosingLayer on a null pointer

In C++, it's not legal to call member functions on objects that are null
pointers.

R=esprehn@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170245

[esprehn, 2014-03-27 23:54:27]

lgtm

https://codereview.chromium.org/215773002/diff/1/Source/core/frame/FrameView.cpp
File Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/215773002/diff/1/Source/core/frame/FrameView....
Source/core/frame/FrameView.cpp:2746: RenderObject* enclosingLayerRenderer =
eltRenderer ? eltRenderer->enclosingLayer()->renderer() : 0;
We should rename eltRenderer too.

https://codereview.chromium.org/215773002/diff/1/Source/core/page/scrolling/S...
File Source/core/page/scrolling/ScrollingCoordinator.cpp (right):

https://codereview.chromium.org/215773002/diff/1/Source/core/page/scrolling/S...
Source/core/page/scrolling/ScrollingCoordinator.cpp:397: if (const RenderObject*
ownerRenderer = child->ownerRenderer()) {
Might be nicer to use a "continue" instead of nesting the whole loop.

https://codereview.chromium.org/215773002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderObject.cpp (right):

https://codereview.chromium.org/215773002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderObject.cpp:533: ASSERT(!m_parent &&
!isRenderView());
I'd ASSERT(isRooted()) at the top and ASSERT_NOT_REACHED() here and make
everyone stop calling this on things outside the tree.

[abarth-chromium, 2014-03-28 00:17:27]

Done

[abarth-chromium, 2014-03-28 00:17:53]

On 2014/03/27 23:54:27, esprehn wrote:
> I'd ASSERT(isRooted()) at the top and ASSERT_NOT_REACHED() here and make
> everyone stop calling this on things outside the tree.

On IRC we decided to add a FIXME for now.

[abarth-chromium, 2014-03-28 00:18:04]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-03-28 00:18:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/215773002/20001

[commit-bot: I haz the power, 2014-03-28 01:21:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 01:21:26]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[esprehn, 2014-03-28 01:22:00]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-03-28 01:22:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/215773002/20001

[commit-bot: I haz the power, 2014-03-28 02:06:47]

Change committed as 170245