third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js - Issue 2157713002: DevTools: introduce View: a named widget with the toolbar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

Issue 2157713002: DevTools: introduce View: a named widget with the toolbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/source_frame/FontView.js ('K') | « third_party/WebKit/Source/devtools/front_end/source_frame/ImageView.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js » ('j') | third_party/WebKit/Source/devtools/front_end/ui/Widget.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

diff --git a/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js b/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

index a8ca998a00aa80f6698d5d440fc5fdc2bc416466..9209bfacc7d62f7a6469527423b618f65d201491 100644

--- a/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

+++ b/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

@@ -30,7 +30,7 @@

/**

* @constructor

- * @extends {WebInspector.VBoxWithToolbarItems}

+ * @extends {WebInspector.View}

* @implements {WebInspector.Searchable}

* @implements {WebInspector.Replaceable}

* @param {string} url

@@ -38,7 +38,7 @@

WebInspector.SourceFrame = function(url, lazyContent)

{

- WebInspector.VBoxWithToolbarItems.call(this);

+ WebInspector.View.call(this, WebInspector.UIString("Source"));

dgozman 2016/07/20 01:37:16 SourceFrame is a view? Sounds bad. Same goes for I

this._url = url;

this._lazyContent = lazyContent;

@@ -645,7 +645,7 @@ WebInspector.SourceFrame.prototype = {

e.consume(true);

- __proto__: WebInspector.VBoxWithToolbarItems.prototype

+ __proto__: WebInspector.View.prototype

}

/**