DevTools: introduce View: a named widget with the toolbar.

third_party/WebKit/Source/devtools/front_end/ui/Widget.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2011 Google Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 617 matching lines @@
     {
         this._resizeCallback();
     },
 
     __proto__: WebInspector.VBox.prototype
 }
 
 /**
  * @constructor
  * @extends {WebInspector.VBox}
+ * @param {string} title
+ * @param {boolean=} isWebComponent
  */
-WebInspector.VBoxWithToolbarItems = function()
+WebInspector.View = function(title, isWebComponent)
 {
-    WebInspector.VBox.call(this);
+    WebInspector.VBox.call(this, isWebComponent);
+    this._title = title;
+    /** @type {!Array<!WebInspector.ToolbarItem>} */
+    this._toolbarItems = [];
 }
 
-WebInspector.VBoxWithToolbarItems.prototype = {
+WebInspector.View.prototype = {
+    /**
+     * @return {string}
+     */
+    title: function()
+    {
+        return this._title;
+    },
+
+    /**
+     * @param {function()} callback
+     */
+    setRevealCallback: function(callback)
+    {
+        this._revealCallback = callback;
+        if (this._setRevealRequested)

[dgozman, 2016/07/20 01:37:16]

delete this._setRevealRequested;

[pfeldman, 2016/07/20 01:45:09]

Done.

+            callback();
+    },
+
+    /**
+     * @param {function(boolean)} callback
+     */
+    setRequestVisibleCallback: function(callback)
+    {
+        this._requestVisibleCallback = callback;
+        if (this._setVisibleRequested !== undefined)

[dgozman, 2016/07/20 01:37:16]

typeof ... !=== "undefined"

[pfeldman, 2016/07/20 01:45:10]

We can now compare to undefined since 2 years ago.

+            callback(this._setVisibleRequested);

[dgozman, 2016/07/20 01:37:16]

delete this._setVisibleRequested;

[pfeldman, 2016/07/20 01:45:09]

Done.

+    },
+
+    requestReveal: function()
+    {
+        this._setRevealRequested = true;
+        if (this._revealCallback)
+            this._revealCallback();

[dgozman, 2016/07/20 01:37:16]

else
    this._setRevealRequested = true;

[pfeldman, 2016/07/20 01:45:10]

Done.

+    },
+
+    /**
+     * @param {boolean} visible
+     */
+    requestSetVisible: function(visible)
+    {
+        this._setVisibleRequested = visible;
+        if (this._requestVisibleCallback)
+            this._requestVisibleCallback(visible);

[dgozman, 2016/07/20 01:37:16]

else
    this._setVisibleRequested = visible;

[pfeldman, 2016/07/20 01:45:09]

Done.

+    },
+
+    /**
+     * @param {!WebInspector.ToolbarItem} item
+     */
+    addToolbarItem: function(item)
+    {
+        this._toolbarItems.push(item);
+    },
+
     /**
      * @return {!Array<!WebInspector.ToolbarItem>}
      */
     toolbarItems: function()
     {
-        return [];
+        return this._toolbarItems;
     },
 
     __proto__: WebInspector.VBox.prototype
 }
 
 /**
  * @override
  * @param {?Node} child
  * @return {?Node}
  * @suppress {duplicate}
@@ skipping 27 matching lines @@
 {
     WebInspector.Widget.__assert(!child.__widgetCounter && !child.__widget, "Attempt to remove element containing widget via regular DOM operation");
     return WebInspector.Widget._originalRemoveChild.call(this, child);
 }
 
 Element.prototype.removeChildren = function()
 {
     WebInspector.Widget.__assert(!this.__widgetCounter, "Attempt to remove element containing widget via regular DOM operation");
     WebInspector.Widget._originalRemoveChildren.call(this);
 }