Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

Issue 2157713002: DevTools: introduce View: a named widget with the toolbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lcean Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 * @return {!WebInspector.ToolbarButton} 176 * @return {!WebInspector.ToolbarButton}
177 */ 177 */
178 toolbarButton: function() 178 toolbarButton: function()
179 { 179 {
180 return this._toolbarButton; 180 return this._toolbarButton;
181 } 181 }
182 } 182 }
183 183
184 /** 184 /**
185 * @constructor 185 * @constructor
186 * @extends {WebInspector.SidebarPane} 186 * @extends {WebInspector.View}
187 * @param {!WebInspector.ExtensionServer} server 187 * @param {!WebInspector.ExtensionServer} server
188 * @param {string} panelName 188 * @param {string} panelName
189 * @param {string} title 189 * @param {string} title
190 * @param {string} id 190 * @param {string} id
191 */ 191 */
192 WebInspector.ExtensionSidebarPane = function(server, panelName, title, id) 192 WebInspector.ExtensionSidebarPane = function(server, panelName, title, id)
193 { 193 {
194 WebInspector.SidebarPane.call(this, title); 194 WebInspector.View.call(this, title);
195 this.element.classList.add("fill");
195 this._panelName = panelName; 196 this._panelName = panelName;
196 this._server = server; 197 this._server = server;
197 this._id = id; 198 this._id = id;
198 } 199 }
199 200
200 WebInspector.ExtensionSidebarPane.prototype = { 201 WebInspector.ExtensionSidebarPane.prototype = {
201 /** 202 /**
202 * @return {string} 203 * @return {string}
203 */ 204 */
204 id: function() 205 id: function()
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 this._objectPropertiesView.element.removeChildren(); 308 this._objectPropertiesView.element.removeChildren();
308 var section = new WebInspector.ObjectPropertiesSection(object, title); 309 var section = new WebInspector.ObjectPropertiesSection(object, title);
309 if (!title) 310 if (!title)
310 section.titleLessMode(); 311 section.titleLessMode();
311 section.expand(); 312 section.expand();
312 section.editable = false; 313 section.editable = false;
313 this._objectPropertiesView.element.appendChild(section.element); 314 this._objectPropertiesView.element.appendChild(section.element);
314 callback(); 315 callback();
315 }, 316 },
316 317
317 __proto__: WebInspector.SidebarPane.prototype 318 __proto__: WebInspector.View.prototype
318 } 319 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698