buildbucket: support unique change urls

scripts/master/buildbucket/unittests/changestore_test.py

 #!/usr/bin/env python
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """changes.ChangeStore unit tests"""
 
 import datetime
 import json
 import unittest
@@ skipping 52 matching lines @@
     change = self.store._find_change(m.revision, m.change_id)
     cache = self.buildbot.change_cache
     cache.get.assert_called_once_with((m.revision, m.change_id))
     self.assertEqual(change, cache.get.return_value)
 
   def test_get_change(self):
     cache = self.buildbot.change_cache
     cache.get.return_value = None
     result = run_deferred(self.store.get_change(self.buildbucket_change))
 
-    info = json.dumps({
+    info = {
         common.BUILDBUCKET_CHANGE_ID_PROPERTY: '1',
-    }, sort_keys=True)
+    }
     self.buildbot.add_change_to_db.assert_called_once_with(
         author=self.buildbucket_change['author']['email'],
         files=[],
         comments=self.buildbucket_change['message'],
         revision=self.buildbucket_change['revision'],
         when_timestamp=datetime.datetime(2014, 12, 22),
         branch=self.buildbucket_change['branch'],
         category=common.CHANGE_CATEGORY,
         revlink=self.buildbucket_change['url'],
         properties={
             common.INFO_PROPERTY: (info, 'Change'),
         },
         repository=self.buildbucket_change.get('repo_url'),
         project=self.buildbucket_change.get('project'),
     )
     self.assertEqual(result, self.buildbot.get_change_by_id.return_value)
 
   def test_get_change_without_id(self):
     cache = self.buildbot.change_cache
     cache.get.return_value = None
     result = run_deferred(self.store.get_change({
         'author': {
             'email': 'johndoe@chromium.org',
         },
         'message': 'Hello world',
     }))
 
-    expected_info = json.dumps({'change_id': None})
+    expected_info = {'change_id': None}
     self.buildbot.add_change_to_db.assert_called_once_with(
         author='johndoe@chromium.org',
         files=[],
         comments='Hello world',
         revision='',
         when_timestamp=None,
         branch=None,
         category=common.CHANGE_CATEGORY,
         revlink='',
         properties={
@@ skipping 34 matching lines @@
     }
     result = run_deferred(
         self.store.get_source_stamp([self.buildbucket_change], cache=ss_cache))
     self.assertFalse(self.buildbot.change_cache.get.called)
     self.assertFalse(self.buildbot.insert_source_stamp_to_db.called)
     self.assertEqual(result, ssid)
 
 
 if __name__ == '__main__':
   unittest.main()