chrome/browser/resources/settings/people_page/setup_pin_dialog.html - Issue 2157673002: Browser tests for the quick_unlock settings pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/setup_pin_dialog.html

Issue 2157673002: Browser tests for the quick_unlock settings pages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pin-unlock-quick-unlock-interface

Patch Set: Address comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/people_page/quick_unlock_choose_method.js ('k') | chrome/browser/resources/settings/people_page/setup_pin_dialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/people_page/setup_pin_dialog.html

diff --git a/chrome/browser/resources/settings/people_page/setup_pin_dialog.html b/chrome/browser/resources/settings/people_page/setup_pin_dialog.html

index 5f2f98f603f54a830c41292cd4dd4fbe3ea59b8d..3f222420dd6eb0ff99e7718f30bf6f1ed205f67f 100644

--- a/chrome/browser/resources/settings/people_page/setup_pin_dialog.html

+++ b/chrome/browser/resources/settings/people_page/setup_pin_dialog.html

@@ -1,6 +1,7 @@

+<link rel="import" href="/icons.html">

@@ -32,10 +33,11 @@

<div class="title">[[getTitleMessage_(isConfirmStep_)]]</div>

-

- <div class$="[[problemClass_]] settings-box first"

+ <!-- Warning/error; only shown if title is hidden. Id is needed for

+ tests. -->

+ <div id="problemDiv" class$="[[problemClass_]] settings-box first"

hidden$="[[!hasProblem_(problemMessage_)]]">

- <iron-icon icon="icons:warning"></iron-icon>

+ <iron-icon icon="settings:warning"></iron-icon>

<span class="middle">[[problemMessage_]]</span>

</div>