Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2157663002: Stop using Numeric.compare(x,y) in Physical Web (Closed)

Created:
4 years, 5 months ago by cco3
Modified:
4 years, 5 months ago
Reviewers:
gone, mattreynolds
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop using Numeric.compare(x,y) in Physical Web Double.compare and Long.compare were introduced in api 19, but the minimum is api 16. This change uses compareTo instead. BUG=628711 Committed: https://crrev.com/1352ffd4b0490107518c8e4bf04ef4ae4682de97 Cr-Commit-Position: refs/heads/master@{#406032}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java View 3 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
cco3
4 years, 5 months ago (2016-07-15 22:33:27 UTC) #2
mattreynolds
lgtm
4 years, 5 months ago (2016-07-15 22:37:04 UTC) #3
gone
lgtm
4 years, 5 months ago (2016-07-15 23:54:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2157663002/1
4 years, 5 months ago (2016-07-18 16:35:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 17:58:33 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 18:00:42 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1352ffd4b0490107518c8e4bf04ef4ae4682de97
Cr-Commit-Position: refs/heads/master@{#406032}

Powered by Google App Engine
This is Rietveld 408576698