Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 215763002: [webcrypto] Add layout tests for garbage collection of custom properties. (Closed)

Created:
6 years, 9 months ago by eroman
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

[webcrypto] Add layout tests for garbage collection of custom properties. These tests come from WebKit's LayoutTests/crypto, with only slight modifications to work in Blink. BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170284

Patch Set 1 #

Patch Set 2 : Upload original WebKit tests #

Patch Set 3 : Modifications for Blink #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -5 lines) Patch
A LayoutTests/crypto/crypto-gc.html View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A + LayoutTests/crypto/crypto-gc-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A LayoutTests/crypto/gc.html View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
A LayoutTests/crypto/gc-2.html View 1 2 1 chunk +46 lines, -0 lines 0 comments Download
A LayoutTests/crypto/gc-2-expected.txt View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/crypto/gc-3.html View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A LayoutTests/crypto/gc-3-expected.txt View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A + LayoutTests/crypto/gc-expected.txt View 1 2 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
eroman
These tests are copied from WebKit, do I need to do anything additional for attribution?
6 years, 9 months ago (2014-03-27 23:35:14 UTC) #1
abarth-chromium
LGTM I don't think you need to do anything particular to attribute them. You can ...
6 years, 9 months ago (2014-03-27 23:45:03 UTC) #2
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-28 00:35:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/215763002/40001
6 years, 9 months ago (2014-03-28 00:35:30 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 00:40:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-28 00:40:51 UTC) #6
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-28 02:18:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/215763002/40001
6 years, 9 months ago (2014-03-28 02:18:27 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 03:22:45 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-28 03:22:46 UTC) #10
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-28 05:23:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/215763002/40001
6 years, 9 months ago (2014-03-28 05:23:06 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 06:31:17 UTC) #13
Message was sent while issue was closed.
Change committed as 170284

Powered by Google App Engine
This is Rietveld 408576698