Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Unified Diff: build/toolchain/mac/BUILD.gn

Issue 2157573002: [Mac/GN] Add a new linker_driver.py option to save unstripped linker output. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Compiler config Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/mac/symbols.gni ('k') | build/toolchain/mac/linker_driver.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/mac/BUILD.gn
diff --git a/build/toolchain/mac/BUILD.gn b/build/toolchain/mac/BUILD.gn
index 72485c050293c84a15d071fe4a330ea62b4a5395..10efb0942063212e029a7f5d5494be5071231eee 100644
--- a/build/toolchain/mac/BUILD.gn
+++ b/build/toolchain/mac/BUILD.gn
@@ -104,10 +104,16 @@ template("mac_toolchain") {
# If dSYMs are enabled, this flag will be added to the link tools.
if (enable_dsyms) {
dsym_switch = " -Wcrl,dsym," + rebase_path(root_out_dir) + " "
+ _dsym_output =
+ "{{root_out_dir}}/{{target_output_name}}{{output_extension}}.dSYM/"
} else {
dsym_switch = ""
}
+ if (save_unstripped_output) {
+ _unstripped_output = "{{root_out_dir}}/{{target_output_name}}{{output_extension}}.unstripped"
+ }
+
tool("cc") {
depfile = "{{output}}.d"
precompiled_header_type = "gcc"
@@ -232,7 +238,10 @@ template("mac_toolchain") {
depend_output = tocname
if (enable_dsyms) {
- outputs += [ "{{root_out_dir}}/{{target_output_name}}{{output_extension}}.dSYM/" ]
+ outputs += [ _dsym_output ]
+ }
+ if (save_unstripped_output) {
+ outputs += [ _unstripped_output ]
}
}
@@ -263,7 +272,10 @@ template("mac_toolchain") {
]
if (enable_dsyms) {
- outputs += [ "{{root_out_dir}}/{{target_output_name}}{{output_extension}}.dSYM/" ]
+ outputs += [ _dsym_output ]
+ }
+ if (save_unstripped_output) {
+ outputs += [ _unstripped_output ]
}
}
@@ -287,7 +299,10 @@ template("mac_toolchain") {
]
if (enable_dsyms) {
- outputs += [ "{{root_out_dir}}/{{target_output_name}}{{output_extension}}.dSYM/" ]
+ outputs += [ _dsym_output ]
+ }
+ if (save_unstripped_output) {
+ outputs += [ _unstripped_output ]
}
default_output_dir = "{{root_out_dir}}"
« no previous file with comments | « build/config/mac/symbols.gni ('k') | build/toolchain/mac/linker_driver.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698