Add a PGO tag for the PGO builds in chrome://version

Add a PGO tag for the PGO builds in chrome://version

Also remove the VS2013 version string as we don't support it anymore.

BUG=309849
Committed: https://crrev.com/cbb31e640ae7ee7a9e03df917d5bba25415c13f0
Cr-Commit-Position: refs/heads/master@{#406119}

[Sébastien Marchand, 2016-07-15 18:39:50]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 18:40:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 18:43:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 18:43:47]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[Sébastien Marchand, 2016-07-15 19:02:51]

The CQ bit was checked by sebmarchand@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 19:03:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sébastien Marchand, 2016-07-15 19:28:06]

sebmarchand@chromium.org changed reviewers:
+ brucedawson@chromium.org

[Sébastien Marchand, 2016-07-15 19:28:07]

WDYT of this ? Right now there's no easy way to tell if a build is a PGO one.

[brucedawson, 2016-07-15 19:43:07]

Seems like a good idea. As long as it works lgtm.

https://codereview.chromium.org/2157563002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/version_ui.cc (right):

https://codereview.chromium.org/2157563002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/version_ui.cc:146: #elif defined(_MSC_VER) && _MSC_VER
== 1800
Could delete this at the same time? I don't know whether that's a good idea or
not.

[commit-bot: I haz the power, 2016-07-15 20:14:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 20:15:00]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Sébastien Marchand, 2016-07-18 19:10:42]

https://codereview.chromium.org/2157563002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/version_ui.cc (right):

https://codereview.chromium.org/2157563002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/version_ui.cc:146: #elif defined(_MSC_VER) && _MSC_VER
== 1800
On 2016/07/15 19:43:07, brucedawson wrote:
> Could delete this at the same time? I don't know whether that's a good idea or
> not.

Yeah, make sense as we don't support VS2013 anymore.

[Sébastien Marchand, 2016-07-18 19:12:05]

Description was changed from

==========
Add a PGO tag for the PGO builds in chrome://version

BUG=309849
==========

to

==========
Add a PGO tag for the PGO builds in chrome://version

Also remove the VS2013 version string as we don't support it anymore.

BUG=309849
==========

[Sébastien Marchand, 2016-07-18 19:12:20]

sebmarchand@chromium.org changed reviewers:
+ sky@chromium.org

[Sébastien Marchand, 2016-07-18 19:12:21]

+sky for owner approval.

[sky, 2016-07-18 20:10:14]

LGTM

[Sébastien Marchand, 2016-07-18 20:30:52]

The CQ bit was checked by sebmarchand@chromium.org

[Sébastien Marchand, 2016-07-18 20:30:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
brucedawson@chromium.org
Link to the patchset: https://codereview.chromium.org/2157563002/#ps40001
(title: "Remove the VS2013 string.")

[commit-bot: I haz the power, 2016-07-18 20:33:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 22:27:04]

Description was changed from

==========
Add a PGO tag for the PGO builds in chrome://version

Also remove the VS2013 version string as we don't support it anymore.

BUG=309849
==========

to

==========
Add a PGO tag for the PGO builds in chrome://version

Also remove the VS2013 version string as we don't support it anymore.

BUG=309849
==========

[commit-bot: I haz the power, 2016-07-18 22:27:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-18 22:27:23]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 22:28:44]

Description was changed from

==========
Add a PGO tag for the PGO builds in chrome://version

Also remove the VS2013 version string as we don't support it anymore.

BUG=309849
==========

to

==========
Add a PGO tag for the PGO builds in chrome://version

Also remove the VS2013 version string as we don't support it anymore.

BUG=309849

Committed: https://crrev.com/cbb31e640ae7ee7a9e03df917d5bba25415c13f0
Cr-Commit-Position: refs/heads/master@{#406119}
==========

[commit-bot: I haz the power, 2016-07-18 22:28:45]

Patchset 3 (id:??) landed as
https://crrev.com/cbb31e640ae7ee7a9e03df917d5bba25415c13f0
Cr-Commit-Position: refs/heads/master@{#406119}

[Sébastien Marchand, 2016-07-18 22:55:10]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2160013003/ by sebmarchand@chromium.org.

The reason for reverting is: It's breaking a chromiumos bot:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%....

[Sébastien Marchand, 2016-07-19 14:04:02]

It looks like I can't use the 'chrome_pgo_phase' variable defined in
build/common.gypi in chrome/chrome_feature.gypi... I'm not sure how to fix this
in GYP but I'll probably just wait for the transition to GN.