Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js

Issue 2157533003: DevTools: Source color picker experiment. Make color swatches clickable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
index 7b3ecb4bb7363269f4ad2588eb3fd1cec52b472f..655f54c1520ebba633da2416f04f39fa621d5781 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
@@ -40,7 +40,7 @@ WebInspector.StylesSidebarPane = function()
WebInspector.moduleSetting("textEditorIndent").addChangeListener(this.update.bind(this));
this._sectionsContainer = this.element.createChild("div");
- this._stylesPopoverHelper = new WebInspector.StylesPopoverHelper();
+ this._iconPopoverHelper = new WebInspector.IconPopoverHelper();
this._linkifier = new WebInspector.Linkifier(new WebInspector.Linkifier.DefaultCSSFormatter());
this.element.classList.add("styles-pane");
@@ -136,7 +136,7 @@ WebInspector.StylesSidebarPane.prototype = {
forceUpdate: function()
{
- this._stylesPopoverHelper.hide();
+ this._iconPopoverHelper.hide();
this._resetCache();
this.update();
},
@@ -490,7 +490,7 @@ WebInspector.StylesSidebarPane.prototype = {
{
this.element.ownerDocument.body.removeEventListener("keydown", this._keyDownBound, false);
this.element.ownerDocument.body.removeEventListener("keyup", this._keyUpBound, false);
- this._stylesPopoverHelper.hide();
+ this._iconPopoverHelper.hide();
this._discardElementUnderMouse();
WebInspector.ElementsSidebarPane.prototype.willHide.call(this);
},
@@ -1958,8 +1958,8 @@ WebInspector.StylePropertyTreeElement.prototype = {
return swatch;
}
- var stylesPopoverHelper = this._parentPane._stylesPopoverHelper;
- var swatchIcon = new WebInspector.ColorSwatchPopoverIcon(this, stylesPopoverHelper, text);
+ var iconPopoverHelper = this._parentPane._iconPopoverHelper;
+ var swatchIcon = new WebInspector.ColorSwatchPopoverIcon(this, iconPopoverHelper, text);
/**
* @param {?Array<string>} backgroundColors
@@ -2013,8 +2013,8 @@ WebInspector.StylePropertyTreeElement.prototype = {
var geometry = WebInspector.Geometry.CubicBezier.parse(text);
if (!geometry || !this._editable())
return createTextNode(text);
- var stylesPopoverHelper = this._parentPane._stylesPopoverHelper;
- return new WebInspector.BezierPopoverIcon(this, stylesPopoverHelper, text).element();
+ var iconPopoverHelper = this._parentPane._iconPopoverHelper;
+ return new WebInspector.BezierPopoverIcon(this, iconPopoverHelper, text).element();
},
_updateState: function()

Powered by Google App Engine
This is Rietveld 408576698