Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2157533002: Submit button on not working. (Closed)

Created:
4 years, 5 months ago by sammiequon
Modified:
4 years, 5 months ago
Reviewers:
xiyuan, jdufault
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Submit button on not working. BUG=627938 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ee492c4358a680f0047a3a29b93ad1d9a2c7a346 Cr-Commit-Position: refs/heads/master@{#406075}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed patch set 1 errors. #

Total comments: 2

Patch Set 3 : Fixed patch set 2 errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/login/account_picker/user_pod_row.js View 1 2 3 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
sammiequon
jdufault@, xiyuan@ - Please take a look.
4 years, 5 months ago (2016-07-15 20:00:48 UTC) #4
jdufault
On 2016/07/15 20:00:48, sammiequon wrote: > jdufault@, xiyuan@ - Please take a look. lgtm after ...
4 years, 5 months ago (2016-07-15 20:05:08 UTC) #5
jdufault
https://codereview.chromium.org/2157533002/diff/1/ui/login/account_picker/user_pod_row.js File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2157533002/diff/1/ui/login/account_picker/user_pod_row.js#newcode716 ui/login/account_picker/user_pod_row.js:716: this.pinKeyboard.addEventListener('submit', Add {} for multiline if statements.
4 years, 5 months ago (2016-07-15 20:05:15 UTC) #6
xiyuan
lgtm
4 years, 5 months ago (2016-07-18 17:45:48 UTC) #7
jdufault
https://codereview.chromium.org/2157533002/diff/20001/ui/login/account_picker/user_pod_row.js File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2157533002/diff/20001/ui/login/account_picker/user_pod_row.js#newcode715 ui/login/account_picker/user_pod_row.js:715: if(this.pinKeyboard) { nit: space after if before (
4 years, 5 months ago (2016-07-18 18:17:26 UTC) #8
sammiequon
https://codereview.chromium.org/2157533002/diff/1/ui/login/account_picker/user_pod_row.js File ui/login/account_picker/user_pod_row.js (right): https://codereview.chromium.org/2157533002/diff/1/ui/login/account_picker/user_pod_row.js#newcode716 ui/login/account_picker/user_pod_row.js:716: this.pinKeyboard.addEventListener('submit', On 2016/07/15 20:05:15, jdufault wrote: > Add {} ...
4 years, 5 months ago (2016-07-18 18:49:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2157533002/40001
4 years, 5 months ago (2016-07-18 18:50:18 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-18 20:04:56 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 20:07:21 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/ee492c4358a680f0047a3a29b93ad1d9a2c7a346
Cr-Commit-Position: refs/heads/master@{#406075}

Powered by Google App Engine
This is Rietveld 408576698