Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2157493003: Revert of bluetooth: Use WebBluetoothDeviceId instead of string (Closed)

Created:
4 years, 5 months ago by wjmaclean
Modified:
4 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, ortuno+watch_chromium.org, qsr+mojo_chromium.org, scheib+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bluetooth-uuid-typemap
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of bluetooth: Use WebBluetoothDeviceId instead of string (patchset #23 id:440001 of https://codereview.chromium.org/2019853002/ ) Reason for revert: Appears to be a possible cause for failing tests: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/43401 https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/24953 Doing speculative revert. Original issue's description: > bluetooth: Use WebBluetoothDeviceId instead of string > > This adds more type safety to our current code and also allows us check the format > of the string that we get from the renderer. > > Also moves the chromium variant bindings generation out of blink.gyp and into > content_common_mojo_bindings.gyp. This avoids adding a dependency to content/common > in blink.gyp since now the chromium bindings depend on > content/common/bluetooth/web_bluetooth_device_id > > CQ_INCLUDE_TRYJOBS=master.tryserver.chromium.mac:mac_chromium_gyp_rel,master.tryserver.chromium.mac:mac_chromium_gyp_dbg > > BUG=577962 > > Committed: https://crrev.com/bd27a25399b274afabd4338a28c5c1f72b37c78c > Cr-Commit-Position: refs/heads/master@{#405806} TBR=dcheng@chromium.org,jam@chromium.org,jbroman@chromium.org,jyasskin@chromium.org,palmer@chromium.org,rockot@chromium.org,ortuno@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=577962 Committed: https://crrev.com/7f83196051c0f4632f2e69d54922ee2a8ed2fea6 Cr-Commit-Position: refs/heads/master@{#405828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -489 lines) Patch
M content/browser/bluetooth/bluetooth_allowed_devices_map.h View 4 chunks +19 lines, -27 lines 0 comments Download
M content/browser/bluetooth/bluetooth_allowed_devices_map.cc View 6 chunks +32 lines, -20 lines 0 comments Download
M content/browser/bluetooth/bluetooth_allowed_devices_map_unittest.cc View 14 chunks +45 lines, -45 lines 0 comments Download
M content/browser/bluetooth/frame_connected_bluetooth_devices.h View 3 chunks +7 lines, -11 lines 0 comments Download
M content/browser/bluetooth/frame_connected_bluetooth_devices.cc View 5 chunks +7 lines, -9 lines 0 comments Download
M content/browser/bluetooth/frame_connected_bluetooth_devices_unittest.cc View 7 chunks +14 lines, -14 lines 0 comments Download
M content/browser/bluetooth/web_bluetooth_service_impl.h View 4 chunks +8 lines, -7 lines 0 comments Download
M content/browser/bluetooth/web_bluetooth_service_impl.cc View 11 chunks +20 lines, -17 lines 0 comments Download
M content/common/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D content/common/bluetooth/OWNERS View 1 chunk +0 lines, -8 lines 0 comments Download
D content/common/bluetooth/PRESUBMIT.py View 1 chunk +0 lines, -14 lines 0 comments Download
D content/common/bluetooth/typemaps.gni View 1 chunk +0 lines, -5 lines 0 comments Download
D content/common/bluetooth/web_bluetooth_device_id.h View 1 chunk +0 lines, -58 lines 0 comments Download
D content/common/bluetooth/web_bluetooth_device_id.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D content/common/bluetooth/web_bluetooth_device_id.typemap View 1 chunk +0 lines, -11 lines 0 comments Download
D content/common/bluetooth/web_bluetooth_device_id_struct_traits.h View 1 chunk +0 lines, -39 lines 0 comments Download
D content/common/bluetooth/web_bluetooth_device_id_unittest.cc View 1 chunk +0 lines, -81 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_common_mojo_bindings.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/bluetooth/web_bluetooth_impl.h View 3 chunks +2 lines, -5 lines 0 comments Download
M content/renderer/bluetooth/web_bluetooth_impl.cc View 4 chunks +9 lines, -12 lines 0 comments Download
M mojo/public/tools/bindings/chromium_bindings_configuration.gni View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/blink.gyp View 4 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom View 3 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
wjmaclean
Created Revert of bluetooth: Use WebBluetoothDeviceId instead of string
4 years, 5 months ago (2016-07-15 19:44:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2157493003/1
4 years, 5 months ago (2016-07-15 19:45:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 19:46:37 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 19:46:44 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 19:48:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f83196051c0f4632f2e69d54922ee2a8ed2fea6
Cr-Commit-Position: refs/heads/master@{#405828}

Powered by Google App Engine
This is Rietveld 408576698