Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1860)

Unified Diff: appengine/findit/crash/scorers/test/min_distance_test.py

Issue 2157433002: [Findit] Pass changed files info to Fracas, 2 face design. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Fix nits. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/scorers/test/min_distance_test.py
diff --git a/appengine/findit/crash/scorers/test/min_distance_test.py b/appengine/findit/crash/scorers/test/min_distance_test.py
index f0acd0377ce7310fcbeff8860561b128081a2b52..4b4f0469b53ca6e7fa134f1624d072e7f02db44d 100644
--- a/appengine/findit/crash/scorers/test/min_distance_test.py
+++ b/appengine/findit/crash/scorers/test/min_distance_test.py
@@ -1,7 +1,7 @@
# Copyright 2016 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-
+from crash.callstack import StackFrame
from crash.results import Result, MatchResult
from crash.scorers.min_distance import MinDistance
from crash.scorers.test.scorer_test_suite import ScorerTestSuite
@@ -12,12 +12,14 @@ class MinDistanceTest(ScorerTestSuite):
def testGetMetric(self):
dummy_changelog = self._GetDummyChangeLog()
match_result = MatchResult(dummy_changelog, 'src/', '')
- match_result.min_distance = 0
+ match_result.file_to_analysis_info = {
+ 'file': {'min_distance': 0, 'min_distance_frame': None}
+ }
self.assertEqual(MinDistance().GetMetric(match_result), 0)
result = Result(dummy_changelog, 'src/', '')
- self.assertEqual(MinDistance().GetMetric(result), None)
+ self.assertEqual(MinDistance().GetMetric(result), float('inf'))
def testScore(self):
self.assertEqual(MinDistance().Score(0), 1)
@@ -26,6 +28,25 @@ class MinDistanceTest(ScorerTestSuite):
def testReason(self):
self.assertEqual(MinDistance().Reason(0, 1),
- 'Modification distance (LOC) is 0')
+ ('MinDistance', 1, 'Minimum distance is 0'))
self.assertEqual(MinDistance().Reason(60, 0),
- '')
+ None)
+
+ def testChangedFiles(self):
+ dummy_changelog = self._GetDummyChangeLog()
+ result = MatchResult(dummy_changelog, 'src/', '')
+ frame = StackFrame(0, 'src/', 'func', 'f.cc', 'a/b/src/f.cc', [2],
+ repo_url='https://repo_url')
+ result.file_to_stack_infos = {
+ 'src/f.cc': [(frame, 0)]
+ }
+ result.file_to_analysis_info = {
+ 'src/f.cc': {'min_distance': 0, 'min_distance_frame': frame}
+ }
+
+ self.assertEqual(MinDistance().ChangedFiles(result),
+ [{'file': 'f.cc',
+ 'blame_url': ('https://repo_url/+blame/%s/f.cc#2' %
+ dummy_changelog.revision),
+ 'info': 'Minimum distance (LOC) 0, frame #0'}])
+
« no previous file with comments | « appengine/findit/crash/scorers/test/aggregators_test.py ('k') | appengine/findit/crash/scorers/test/top_frame_index_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698