[Findit] Pass changed files info to Fracas, 2 face design.

appengine/findit/crash/callstack.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 
 from crash import parse_util
 from crash.type_enums import CallStackFormatType
 
 # Used to parse a line into StackFrame of a Callstack.
@@ skipping 18 matching lines @@
       this - '#0 ...', else use the index in the callstack list.
     dep_path (str): Path of the dep this frame represents, for example,
       'src/', 'src/v8', 'src/skia'...etc.
     function (str): Function that caused the crash.
     file_path (str): Normalized path of the crashed file, with parts dep_path
       and parts before it stripped, for example, api.cc.
     raw_file_path (str): Normalized original path of the crashed file,
       for example, /b/build/slave/mac64/build/src/v8/src/heap/
       incremental-marking-job.cc.
     crashed_line_numbers (list): Line numbers of the file that caused the crash.
+    repo_url (str): Repo url of this frame.
   """
   def __init__(self, index, dep_path, function,
-               file_path, raw_file_path, crashed_line_numbers):
+               file_path, raw_file_path, crashed_line_numbers,
+               repo_url=None):
     self.index = index
     self.dep_path = dep_path
     self.function = function
     self.file_path = file_path
     self.raw_file_path = raw_file_path
     self.crashed_line_numbers = crashed_line_numbers
+    self.repo_url = repo_url
 
   def ToString(self):
     frame_str = '#%d in %s @ %s' % (self.index, self.function, self.file_path)
     if self.crashed_line_numbers:
       frame_str += ':%d' % self.crashed_line_numbers[0]
 
     # For example, if crashed_line_numbers is [61], returns '... f.cc:61',
     # if is [61, 62], returns '... f.cc:61:1'
     if len(self.crashed_line_numbers) > 1:
       frame_str += ':%d' % (len(self.crashed_line_numbers) - 1)
 
     return frame_str
 
+  def BlameUrl(self, revision):
+    if not self.repo_url or not self.dep_path:

[stgao, 2016/07/15 23:25:28]

why dep_path instead of file_path?

[Sharu Jiang, 2016/07/18 00:31:58]

For some frames, findit cannot find a repo match, it will just set the file_path
as the original file path with out repo_path stripped.

so we always have the file_path, but only have repo_path for those we find a
repo.

+      return None
+
+    blame_url = '%s/+blame/%s/%s' % (self.repo_url, revision, self.file_path)
+    if self.crashed_line_numbers:
+      blame_url += '#%d' % self.crashed_line_numbers[0]
+
+    return blame_url
+
   def __str__(self):
     return self.ToString()
 
 
 class CallStack(list):
   """Represents a call stack within a stacktrace. A list of StackFrame objects.
 
   Attributes:
     priority (int): The smaller the number, the higher the priority beginning
       with 0.
@@ skipping 50 matching lines @@
       match = line_pattern.match(line_parts[-1])
       if not match:
         return
 
       function = ' '.join(line_parts[3:-1])
       raw_file_path = match.group(1)
       crashed_line_numbers = parse_util.GetCrashedLineRange(
           match.group(2) + (match.group(3) if match.group(3) else ''))
 
     # Normalize the file path so that it can be compared to repository path.
-    dep_path, file_path = parse_util.GetDepPathAndNormalizedFilePath(
+    dep_path, file_path, repo_url = parse_util.GetDepPathAndNormalizedFilePath(
         raw_file_path, deps)
 
     # If we have the common stack frame index pattern, then use it
     # since it is more reliable.
     index_match = FRAME_INDEX_PATTERN.match(line)
     if index_match:
       stack_frame_index = int(index_match.group(1))
     else:
       stack_frame_index = len(self)
 
-    self.append(StackFrame(stack_frame_index, dep_path, function,
-                           file_path, raw_file_path, crashed_line_numbers))
+    self.append(StackFrame(stack_frame_index, dep_path, function, file_path,
+                           raw_file_path, crashed_line_numbers, repo_url))