Issue 215743002: Mojo: update web ui for the addition of connection.js and router.js

Issue 215743002: Mojo: update web ui for the addition of connection.js and router.js (Closed)

Created:
6 years, 9 months ago by darin (slow to review)

Modified:
6 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, viettrungluu+watch_chromium.org, jam, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: update web ui for the addition of connection.js and router.js BUG=357294 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260084

Patch Set 2 : rebase #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -14 lines)			Patch
M	content/browser/webui/web_ui_data_source_impl.cc	View		1 chunk	+13 lines, -3 lines	0 comments	Download
M	content/browser/webui/web_ui_mojo_browsertest.cc	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	content/content_resources.grd	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/test/data/web_ui_mojo.js	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	mojo/public/bindings/js/constants.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	mojo/public/bindings/js/constants.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

The CQ bit was checked by darin@chromium.org

6 years, 9 months ago (2014-03-28 00:00:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/215743002/1

6 years, 9 months ago (2014-03-28 00:02:46 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 9 months ago (2014-03-28 02:29:46 UTC) #5

commit-bot: I haz the power

Retried try job too often on ios_dbg_simulator for step(s) components_unittests, net_unittests, sql_unittests, ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=136601

6 years, 9 months ago (2014-03-28 02:29:47 UTC) #6

darin (slow to review)

6 years, 9 months ago (2014-03-28 07:23:02 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 manually as r260084 (presubmit successful).

Expand Messages | Collapse Messages